Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DML Insert and Update examples to README #2121

Closed
wants to merge 1 commit into from

Conversation

jsimonweb
Copy link

No description provided.

@jsimonweb jsimonweb requested a review from jdpedrie as a code owner July 17, 2019 19:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the general conventions on the new samples line up with the existing examples? i.e., don't wrap in a function and use SpannerClient::connect() with dummy string values.

@dwsupplee
Copy link
Contributor

Thanks @jsimonweb! :)

I agree with @jdpedrie on keeping the samples in line with what we already have.

Also, If we add these alongside some of our existing snippets we'd be able to take advantage of our snippet testing suite to make sure the samples don't fall out of date in the future. Traditionally we've tried to keep the samples in the READMEs pretty dry for this very reason.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #2121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2121   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity     4379     4379           
=========================================
  Files           304      304           
  Lines         13014    13014           
=========================================
  Hits          12048    12048           
  Misses          966      966

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8d42b...7815d62. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #2121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2121   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity     4379     4379           
=========================================
  Files           304      304           
  Lines         13014    13014           
=========================================
  Hits          12048    12048           
  Misses          966      966

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8d42b...7815d62. Read the comment docs.

@dwsupplee
Copy link
Contributor

Closing in favor of #2269

@dwsupplee dwsupplee closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants