docs: Update documentation and generated tests. #2013

yoshi-automation · 2019-06-04T19:29:06Z

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Speech/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/speech/artman_speech_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-speech-v1.
synthtool > Running generator for google/cloud/speech/artman_speech_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-speech-v1p1beta1.
synthtool > Replaced 'Copyright \\d{4}' in src/V1p1beta1/Gapic/SpeechGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SpeechGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1p1beta1/Gapic/SpeechGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1p1beta1/SpeechSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/SpeechSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Snippet/V1/SpeechClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1p1beta1/SpeechClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpeechClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpeechClientExtensionTest.php.
synthtool > No replacements made in src/*/Gapic/SpeechGapicClient.php for pattern RecognitionConfig_AudioEncoding, maybe replacement is not longer needed?
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/RecognitionConfig_AudioEncoding.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/RecognitionMetadata_RecordingDeviceType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/RecognitionMetadata_MicrophoneDistance.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/RecognitionMetadata_InteractionType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/RecognitionMetadata_OriginalMediaType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1p1beta1/StreamingRecognizeResponse_SpeechEventType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RecognitionConfig_AudioEncoding.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RecognitionMetadata_RecordingDeviceType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RecognitionMetadata_MicrophoneDistance.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RecognitionMetadata_InteractionType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/RecognitionMetadata_OriginalMediaType.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/StreamingRecognizeResponse_SpeechEventType.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

…nt library generator.

dwsupplee · 2019-06-04T20:03:57Z

Speech/src/V1/Gapic/SpeechGapicClient.php

@@ -55,7 +55,7 @@
 * ```
 * $speechClient = new SpeechClient();
 * try {
- *     $encoding = RecognitionConfig\AudioEncoding::FLAC;
+ *     $encoding = AudioEncoding::FLAC;


/cc @hzyi-google

Looks like there could be an issue related to googleapis/gapic-generator#2757

The Google\Cloud\Speech\V1\RecognitionConfig\AudioEncoding import is missing.

This small sample here does not have an import section at all, the imports above are for the client I think. The type is imported in unit tests and smoke tests.

That's a really good point. Based on your experience with the generator, do you think it would be difficult to add imports into the samples as well?

I don't think so, considering the imports for standalone samples are already there.

codecov · 2019-06-05T19:42:08Z

Codecov Report

Merging #2013 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2013      +/-   ##
============================================
+ Coverage     92.56%   92.57%   +<.01%     
- Complexity     4374     4378       +4     
============================================
  Files           303      304       +1     
  Lines         12996    13012      +16     
============================================
+ Hits          12030    12046      +16     
  Misses          966      966

Impacted Files	Coverage Δ	Complexity Δ
Datastore/src/Connection/Grpc.php	`98.08% <0%> (ø)`	`48% <0%> (ø)`	⬇️
Core/src/Compute/Metadata/Readers/StreamReader.php	`100% <0%> (ø)`	`2% <0%> (ø)`	⬇️
Core/src/Compute/Metadata.php	`100% <0%> (ø)`	`10% <0%> (+1%)`	⬆️
...src/Compute/Metadata/Readers/HttpHandlerReader.php	`100% <0%> (ø)`	`3% <0%> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a0b3...2d3e5e4. Read the comment docs.

googlebot · 2019-06-24T18:21:13Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-06-24T19:31:14Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[CHANGE ME] Re-generated Speech to pick up changes in the API or clie…

1051407

…nt library generator.

yoshi-automation requested a review from dwsupplee as a code owner June 4, 2019 19:29

yoshi-automation added the api: speech Issues related to the Speech-to-Text API. label Jun 4, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019

dwsupplee reviewed Jun 4, 2019

View reviewed changes

dwsupplee changed the title ~~[CHANGE ME] Re-generated Speech to pick up changes in the API or client library generator.~~ test: Update generated unit tests. Jun 4, 2019

jdpedrie added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 5, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019

yoshi-automation added the 🚨 This issue needs some love. label Jun 11, 2019

jdpedrie added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Jun 12, 2019

Fix samples class references

2d3e5e4

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 24, 2019

jdpedrie changed the title ~~test: Update generated unit tests.~~ docs: Update documentation and generated tests. Jun 24, 2019

jdpedrie approved these changes Jun 24, 2019

View reviewed changes

jdpedrie removed the needs work This is a pull request that needs a little love. label Jun 24, 2019

yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019

dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed 🚨 This issue needs some love. cla: no This human has *not* signed the Contributor License Agreement. labels Jun 24, 2019

dwsupplee mentioned this pull request Jun 24, 2019

Include imports in code snippets googleapis/gapic-generator#2855

Closed

dwsupplee approved these changes Jun 24, 2019

View reviewed changes

dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2019

yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019

kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 24, 2019

dwsupplee removed the 🚨 This issue needs some love. label Jun 24, 2019

dwsupplee merged commit aba343b into master Jun 24, 2019

jdpedrie mentioned this pull request Jun 27, 2019

Prepare v0.105.0 #2072

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Update documentation and generated tests. #2013

docs: Update documentation and generated tests. #2013

yoshi-automation commented Jun 4, 2019

dwsupplee Jun 4, 2019

yihanzhen Jun 4, 2019

dwsupplee Jun 4, 2019

yihanzhen Jun 5, 2019

codecov bot commented Jun 5, 2019 •

edited

Loading

googlebot commented Jun 24, 2019

googlebot commented Jun 24, 2019

docs: Update documentation and generated tests. #2013

docs: Update documentation and generated tests. #2013

Conversation

yoshi-automation commented Jun 4, 2019

dwsupplee Jun 4, 2019

Choose a reason for hiding this comment

yihanzhen Jun 4, 2019

Choose a reason for hiding this comment

dwsupplee Jun 4, 2019

Choose a reason for hiding this comment

yihanzhen Jun 5, 2019

Choose a reason for hiding this comment

codecov bot commented Jun 5, 2019 • edited Loading

Codecov Report

googlebot commented Jun 24, 2019

googlebot commented Jun 24, 2019

codecov bot commented Jun 5, 2019 •

edited

Loading