Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import, export and delete instance methods. #2011

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Redis/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/redis/artman_redis_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-redis-v1beta1.
synthtool > Running generator for google/cloud/redis/artman_redis_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-redis-v1.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/CloudRedisGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1beta1/Gapic/CloudRedisGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/CloudRedisClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1beta1/CloudRedisClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/CloudRedisClientPartialVeneerTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/CloudRedisClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1beta1/CloudRedisClientPartialVeneerTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1beta1/CloudRedisClientTest.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/Instance_Tier.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/Instance_State.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1/FailoverInstanceRequest_DataProtectionMode.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1beta1/Instance_Tier.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1beta1/Instance_State.php.
synthtool > Replaced 'will be removed in the next major release' in src/V1beta1/FailoverInstanceRequest_DataProtectionMode.php.
synthtool > No replacements made in src/**/Gapic/CloudRedisGapicClient.php for pattern Instance_Tier, maybe replacement is not longer needed?
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: redis Issues related to the Memorystore for Redis API. label Jun 4, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bb0a0b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2011   +/-   ##
=========================================
  Coverage          ?   92.56%           
  Complexity        ?     4374           
=========================================
  Files             ?      303           
  Lines             ?    12996           
  Branches          ?        0           
=========================================
  Hits              ?    12030           
  Misses            ?      966           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a0b3...e2e4879. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #2011 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2011      +/-   ##
============================================
+ Coverage     92.56%   92.57%   +<.01%     
- Complexity     4374     4378       +4     
============================================
  Files           303      304       +1     
  Lines         12996    13012      +16     
============================================
+ Hits          12030    12046      +16     
  Misses          966      966
Impacted Files Coverage Δ Complexity Δ
Datastore/src/Connection/Grpc.php 98.08% <0%> (ø) 48% <0%> (ø) ⬇️
Core/src/Compute/Metadata/Readers/StreamReader.php 100% <0%> (ø) 2% <0%> (ø) ⬇️
Core/src/Compute/Metadata.php 100% <0%> (ø) 10% <0%> (+1%) ⬆️
...src/Compute/Metadata/Readers/HttpHandlerReader.php 100% <0%> (ø) 3% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a0b3...66c6586. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 11, 2019
@jdpedrie jdpedrie added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Jun 12, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 24, 2019
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Redis to pick up changes in the API or client library generator. Add import, export and delete instance methods. Jun 24, 2019
@jdpedrie jdpedrie removed the needs work This is a pull request that needs a little love. label Jun 24, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed 🚨 This issue needs some love. cla: no This human has *not* signed the Contributor License Agreement. labels Jun 24, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019
@jdpedrie jdpedrie merged commit 256c0e9 into master Jun 24, 2019
@jdpedrie jdpedrie mentioned this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: redis Issues related to the Memorystore for Redis API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants