Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ApplicationServiceClient and TenantServiceClient. #1799

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Add ApplicationServiceClient and TenantServiceClient. #1799

merged 2 commits into from
Apr 2, 2019

Conversation

jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Apr 2, 2019

No description provided.

@jdpedrie jdpedrie added the api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) label Apr 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #1799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1799   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...a75b745. Read the comment docs.

dwsupplee
dwsupplee suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add the new clients to our docs?

@jdpedrie
Copy link
Contributor Author

jdpedrie commented Apr 2, 2019

@dwsupplee done!

@codecov-io
Copy link

codecov-io commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #1799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1799   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...c6b4afe. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Apr 2, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #1799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1799   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity     4360     4360           
=========================================
  Files           304      304           
  Lines         12901    12901           
=========================================
  Hits          11809    11809           
  Misses         1092     1092

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1783a...c6b4afe. Read the comment docs.

@dwsupplee
Copy link
Contributor

Thanks @jdpedrie

@dwsupplee dwsupplee merged commit a125be0 into googleapis:master Apr 2, 2019
@jdpedrie jdpedrie mentioned this pull request Apr 2, 2019
Merged
@jdpedrie jdpedrie deleted the talent-gapic branch April 9, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: talent talent.googleapis.com (DO NOT CHANGE LABEL NAME) cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdpedrie @codecov-io @dwsupplee @googlebot