Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Replace InternalChecker project_id with peer_project_id. #1503

Merged
merged 1 commit into from
Dec 17, 2018
Merged

[Breaking Change] Replace InternalChecker project_id with peer_project_id. #1503

merged 1 commit into from
Dec 17, 2018

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > You are running the synthesis script directly, this will be disabled in a future release of Synthtool. Please use python3 -m synthtool instead.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:2f6b261ee7fe1aedf238991c93a20b3820de37a343d0cacf3e3e9555c2aaf2ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/monitoring/artman_monitoring.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-monitoring-v3.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/Gapic/GroupServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/GroupServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/Gapic/MetricServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/MetricServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/Gapic/UptimeCheckServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/UptimeCheckServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/Gapic/AlertPolicyServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/AlertPolicyServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/Gapic/NotificationChannelServiceGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V3/NotificationChannelServiceClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V3/MetricServiceSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V3/GroupServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V3/MetricServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V3/AlertPolicyServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V3/UptimeCheckServiceClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V3/NotificationChannelServiceClientTest.php.
synthtool > Replaced 'ListTimeSeriesRequest_TimeSeriesView' in src/V3/Gapic/MetricServiceGapicClient.php.
synthtool > Cleaned up 1 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2018
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Monitoring to pick up changes in the API or client library generator. [Breaking Change] Replace InternalChecker project_id with peer_project_id. Nov 23, 2018
@jdpedrie jdpedrie added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 23, 2018
@jdpedrie
Copy link
Contributor

@danoscarmike did we get any guidance from the monitoring team on these breaking changes?

@theacodes theacodes reopened this Dec 7, 2018
@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 14, 2018

@jdpedrie All right, we decided to proceed with this change. I'm going to merge this unless anyone objects.

@jdpedrie
Copy link
Contributor

@tmatsuo sounds good.

@jdpedrie jdpedrie merged commit f680f56 into master Dec 17, 2018
@jdpedrie jdpedrie deleted the autosynth-monitoring branch December 17, 2018 16:12
@jdpedrie jdpedrie mentioned this pull request Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoshi-automation @jdpedrie @tmatsuo @theacodes @googlebot