Fix tests for HHVM compat and pin HHVM version #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
approved these changes
May 7, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started seeing HHVM failures on Travis this morning, seemingly related to a new version (v3.26) of HHVM released today. This change addresses all but one of those errors, most of which were related to incorrect casing in classnames in unit tests.
The more complicated side is an error from the snippet parser, raising a fatal error and stopping the build.
The installed version of
nikic/php-parserisv1.4.1, but a brief look at the project seems to indicate that this issue will also exist in the latest iteration.The temporary solution included in this PR is to pin the HHVM version to the last known working version. I'll open a tracking issue to follow this PR where I'll work on figuring out a way to remove the pin and get our builds working on the latest version of HHVM.