Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Dlp #1001

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Refresh Dlp #1001

merged 3 commits into from
Apr 11, 2018

Conversation

michaelbausor
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2018
jdpedrie
jdpedrie suggested changes Apr 9, 2018
View reviewed changes
Dlp/src/V2/Gapic/DlpServiceGapicClient.php Outdated
@@ -1427,11 +1429,7 @@ public function deleteDeidentifyTemplate($name, $optionalArgs = [])
* Optional.
*
* @type InspectJobConfig $inspectJob

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee
dwsupplee reviewed Apr 10, 2018
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one little item.

Dlp/src/V2/Gapic/DlpServiceGapicClient.php Outdated
@@ -1425,7 +1427,7 @@ public function deleteDeidentifyTemplate($name, $optionalArgs = [])
* @param string $parent The parent resource name, for example projects/my-project-id.
* @param array $optionalArgs {
* Optional.
*

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jdpedrie
Copy link
Contributor

jdpedrie commented Apr 10, 2018 •
edited
Loading

The build failure is from dwsupplee/google-cloud-php. For some reason, that is reporting to this PR. The equivalent build on googlecloudplatform/google-cloud-php is green.

@dwsupplee dwsupplee merged commit d92bc04 into googleapis:master Apr 11, 2018
@dwsupplee dwsupplee mentioned this pull request Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbausor @jdpedrie @dwsupplee @googlebot