Add protobuf and grpc recommendations which I missed before (#815)

googleapis · Dec 22, 2017 · ed7b7c0 · ed7b7c0
1 parent 7115ca0
commit ed7b7c0
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 0 deletions.
diff --git a/src/Dataproc/composer.json b/src/Dataproc/composer.json
@@ -20,5 +20,8 @@
         "ext-grpc": "*",
         "google/proto-client": "^0.29.0",
         "google/gax": "^0.28.0"
+    },
+    "suggest": {
+        "ext-protobuf": "Provides a significant increase in throughput over the pure PHP protobuf implementation. See https://cloud.google.com/php/grpc for installation instructions."
     }
 }
diff --git a/src/OsLogin/composer.json b/src/OsLogin/composer.json
@@ -20,5 +20,8 @@
         "ext-grpc": "*",
         "google/proto-client": "^0.29.0",
         "google/gax": "^0.28.0"
+    },
+    "suggest": {
+        "ext-protobuf": "Provides a significant increase in throughput over the pure PHP protobuf implementation. See https://cloud.google.com/php/grpc for installation instructions."
     }
 }
diff --git a/src/Trace/README.md b/src/Trace/README.md
@@ -11,6 +11,10 @@
 support requests, bug reports, or development contributions should be directed to
 that project.
 
+Use of the included generated clients requires installation of the gRPC PHP extension. For instructions, [see here](https://cloud.google.com/php/grpc).
+
+NOTE: In addition to the gRPC extension, we recommend installing the protobuf extension for improved performance. For installation instructions, [see here](https://cloud.google.com/php/grpc#install_the_protobuf_runtime_library).
+
 ## Installation
 
 Install with `composer` or add to your `composer.json`.

diff --git a/src/Trace/composer.json b/src/Trace/composer.json
@@ -10,6 +10,8 @@
         "google/proto-client": "^0.29.0"
     },
     "suggest": {
+        "ext-grpc": "The gRPC extension enables use of the performant gRPC transport",
+        "ext-protobuf": "Provides a significant increase in throughput over the pure PHP protobuf implementation. See https://cloud.google.com/php/grpc for installation instructions.",
         "cache/apcu-adapter": "Enable QpsSampler to use apcu cache.",
         "cache/apc-adapter": "Enable QpsSampler to use apc cache.",
         "cache/memcached-adapter": "Enable QpsSampler to use memcached cache."

diff --git a/src/Vision/composer.json b/src/Vision/composer.json
@@ -9,6 +9,8 @@
         "google/gax": "^0.28"
     },
     "suggest": {
+        "ext-grpc": "The gRPC extension enables use of the performant gRPC transport",
+        "ext-protobuf": "Provides a significant increase in throughput over the pure PHP protobuf implementation. See https://cloud.google.com/php/grpc for installation instructions.",
         "google/cloud-storage": "Annotate images stored in Google Cloud Storage"
     },
     "extra": {