feat(Storage): enable hierarchical namespace (#7292)

googleapis · May 6, 2024 · c6f645f · c6f645f
1 parent 9ad2e3d
commit c6f645f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/Storage/src/StorageClient.php b/Storage/src/StorageClient.php
@@ -292,6 +292,8 @@ function (array $bucket) use ($userProject) {
      *           set in conjunction. For more information, see
      *           [Bucket Locations](https://cloud.google.com/storage/docs/locations).
      *           **Defaults to** `"US"`.
+     *     @type array $hierarchicalNamespace The hierarchical namespace configuration
+     *           on this bucket.
      *     @type array $customPlacementConfig The bucket's dual regions. For more
      *           information, see
      *           [Bucket Locations](https://cloud.google.com/storage/docs/locations).

diff --git a/Storage/tests/System/ManageBucketsTest.php b/Storage/tests/System/ManageBucketsTest.php
@@ -104,6 +104,21 @@ public function testCreatesDualRegionBucket()
         );
     }
 
+    /**
+     * @dataProvider hnsConfigs
+     */
+    public function testCreateBucketsWithHnsConfigs($hnsConfig, $expectedHnsEnabled)
+    {
+        $name = uniqid(self::TESTING_PREFIX);
+
+        $this->assertFalse(self::$client->bucket($name)->exists());
+        $bucket = self::createBucket(self::$client, $name, $hnsConfig);
+
+        $this->assertTrue(self::$client->bucket($name)->exists());
+        $this->assertEquals($name, $bucket->name());
+        $this->assertEquals($expectedHnsEnabled, $bucket->info()['hierarchicalNamespace']['enabled'] ?? false);
+    }
+
     public function testUpdateBucket()
     {
         $options = [
@@ -464,4 +479,16 @@ public function autoclassConfigs()
             [['enabled' => true, 'terminalStorageClass' => 'ARCHIVE']],
         ];
     }
+
+    public function hnsConfigs()
+    {
+        return [
+            [[], false],
+            [['hierarchicalNamespace' => ['enabled' => false,]], false],
+            [[
+                'hierarchicalNamespace' => ['enabled' => true,],
+                'iamConfiguration' => ['uniformBucketLevelAccess' => ['enabled' => true]]
+            ], true],
+        ];
+    }
 }