chore: ExponentialBackoff UT throws risky warning (#6126)

googleapis · Apr 28, 2023 · 35c8f95 · 35c8f95
1 parent 776eca3
commit 35c8f95
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/Core/tests/Unit/ExponentialBackoffTest.php b/Core/tests/Unit/ExponentialBackoffTest.php
@@ -167,6 +167,8 @@ public function delayProvider()
      */
     public function testRetryListener()
     {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Intentionally failing request');
         $args = ['foo' => 'bar'];
         $retryListener = function (
             $ex,
@@ -180,17 +182,11 @@ public function testRetryListener()
         // Setting $retries to 0 so that retry doesn't happens after first
         // failure.
         $backoff = new ExponentialBackoff(0, null, $retryListener);
-        try {
-            $backoff->execute(
-                function () {
-                    throw new \Exception('Intentionally failing request');
-                },
-                [$args]
-            );
-        } catch (\Exception $err) {
-            // Do nothing.
-            // Catching the intentional failing call being made above:
-            // "Intentionally failing request"
-        }
+        $backoff->execute(
+            function () {
+                throw new \Exception('Intentionally failing request');
+            },
+            [$args]
+        );
     }
 }