compute: detachDisk disk cache #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
| } | ||
| ] | ||
| vm.getMetadata = function(callback) { | ||
| vm.METADATA = METADATA; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Gotta update the test that checks the error message. |
Ah shoot, I only changed it to satisfy lint rules. My bad! |
|
Woo, thanks for catching this! |
stephenplusplus
added a commit
that referenced
this pull request
Nov 9, 2015
compute: detachDisk disk cache
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
feat: added ConversationModel resource and its APIs feat: added ConversationDataset resource and its APIs feat: added SetSuggestionFeatureConfig and ClearSuggestionFeatureConfig APIs for ConversationProfile feat: added new knowledge type of Document content feat: added states of Document feat: added metadata for the Knowledge operation docs: updated copyright PiperOrigin-RevId: 430829291 Source-Link: googleapis/googleapis@83795dd Source-Link: googleapis/googleapis-gen@b6b58a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjZiNThhNGQ5YjJjZDY2NTdiYjZkNjQwNmM5MDFmMTZkMWQ1MjEzZiJ9 See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md docs: clarified the behavior of language_code in EventInput in the context of a followup event input docs: clarified wording around Cloud Storage usage docs: added a new resource name pattern for ConversationModel PiperOrigin-RevId: 432962774 Source-Link: googleapis/googleapis@5556688 Source-Link: googleapis/googleapis-gen@ca6f30a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2E2ZjMwYTIyMzM0NjlmZjdkYTM2MWZlOWZiNzg3ODRkY2JjNmM3ZSJ9 chore: update v2.14.1 gapic-generator-typescript Committer: @summer-ji-eng PiperOrigin-RevId: 433031262 Source-Link: googleapis/googleapis@2a55d13 Source-Link: googleapis/googleapis-gen@2fce389 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZjZTM4OTNhZTlkYTQ3NzYzZTA4NzJjNGEzYTg3ZDlmZjc4NzcxZiJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#929 introduced a bug where we wouldn't update the disk cache (metadata) before detaching a disk if the metadata already was present. This logic was a problem because it wasn't accounting for metadata being out of sync.