Bring test coverage to 100% #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -281,6 +279,18 @@ describe('BigQuery/Table', function() { | |||
| table.createWriteStream(fileType).emit('writing'); | |||
| }); | |||
|
|
|||
| it('should format a schema', function(done) { | |||
| var expectedSchema = Table.createSchemaFromString_(SCHEMA_STRING); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--coverage-coverage
branch
from
d4f3fb7 to
1fe093a
Compare
| return (tableOverrides[tableMethod] || tableCached[tableMethod]) | ||
| .apply(this, arguments); | ||
| }; | ||
| }); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--coverage-coverage
branch
from
1fe093a to
87e6343
Compare
| it('should add success redirect', function(done) { | ||
| file.getSignedPolicy({ | ||
| expires: Date.now() + 5, | ||
| successRedirect: 'redirect' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tests: cover bigquery/table leaks tests: cover datastore/transaction leaks tests: cover datastore/dataset leaks tests: cover storage/file leaks tests: cover storage/bucket leaks tests: cover search/index leaks tests: cover storage/acl leaks tests: cover dns/zone leaks tests: cover datastore/entity leaks tests: cover pubsub/subscription leaks
stephenplusplus
force-pushed
the
spp--coverage-coverage
branch
from
87e6343 to
3713fa5
Compare
callmehiphop
added a commit
that referenced
this pull request
Sep 17, 2015
Bring test coverage to 100%
|
Now we have to work to keep it at 100% forever! |
|
Woo! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* docs: clarified some LRO types PiperOrigin-RevId: 394302922 Source-Link: googleapis/googleapis@cd16abb Source-Link: googleapis/googleapis-gen@64782e6 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeffrey Rennie <[email protected]>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Summer Ji <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Summer Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... I think. Running
npm coverdoesn't work on my end.But, I went over all of these < 100% files: https://coveralls.io/builds/3590802 and covered up the holes.
Along the way, I also caught some places we were inconsistent with our
setMetadatamethod. The signature is supposed to be:But some places, it was:
Coincidentally,
apiResponseandmetadatawould have been the same thing-- the apiResponse is what becomes the metadata. Now, however, it's onlyfunction(err, apiResponse) {}so that if an error occurs, the handler still gets the benefit of receiving the API response.