Fixed issue where read streams on files were never ending.

[nemo]

Hey folks,

We were having issues with createReadStream never firing the end event.

Looks like you introduced this bug a few days ago after your recent refactor around streams. It was working fine for us until we upgraded.

Cheers.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[nemo]

Also, just signed the agreement :)

[googlebot]

CLAs look good, thanks!

[stephenplusplus]

Thank you for contributing! Just to confirm, you were having issues with master? Could you paste the code that we could use to reproduce? The stream should be ending itself, so it's possible the stream you're piped to isn't fully consuming the data (or a myriad of other problems!)

[nemo]

It may have been. It looks like you just recently made a few changes to your package.json – let me re-install and let you know if I'm facing this issue.

[nemo]

@stephenplusplus – looks like 0.20 fixes the issue! I was on 0.18 before.

Closing this!

[stephenplusplus]

Great, glad it got sorted out. Please come back if you come across any new strangeness!