storage: allow more time for signed urls to expire #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
api: storage
googlebot
added
the
cla: yes
callmehiphop
added a commit
that referenced
this pull request
Aug 31, 2015
…-fixes storage: allow more time for signed urls to expire
|
Thanks! |
|
crossing fingers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #835, I only allowed 5 milliseconds for a signed link to expires. It used to be interpreted as seconds, so I glossed right over this while changing the code over. It passed locally of course, but since Travis takes his time with everything, he was not pleased.
I changed it back to 5 seconds (5000 ms) and added some more error handling that was previously overlooked.