Do not document queries as supporting multiple kinds #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM if this is all the places where |
|
I'll double check. |
|
I added a couple changes so that the code more closely matches the documentation. I also removed a test that will continue to pass, but is against what our library should support. |
|
PTAL |
|
If those are all the places we talk about multiple kinds, then LGTM. |
|
Yep! |
ryanseys
added a commit
that referenced
this pull request
May 19, 2015
Do not document queries as supporting multiple kinds
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9777e4fc-493b-4824-939e-2bf12cea9581/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 345596855 Source-Link: googleapis/googleapis@d189e87
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
* updating readme with links to vertex ai * chore: updating readme with links to vertex ai * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
Updated the documentation to not make people think we support multiple kinds. The code automatically arrayizes the
kindgiven as required by the backend API.