-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix https to http redirect #596
Conversation
Woah -- good to know. LGTM |
I additionally contacted GitHub about the issue. I'll report back if they say anything but otherwise this should fix things on our end. |
Here's the reply I received:
So there's really no protection except just to make our users feel warm and fuzzy inside. |
Ugh, thumbs down GitHub! But at least they'll look into it. Welp, warm fuzzy green lock thing is there at least... |
🤖 I have created a release \*beep\* \*boop\* --- ### [4.2.6](https://www.github.com/googleapis/nodejs-language/compare/v4.2.5...v4.2.6) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#595](https://www.github.com/googleapis/nodejs-language/issues/595)) ([3ac3cfb](https://www.github.com/googleapis/nodejs-language/commit/3ac3cfb8d0ce0ba055502e07178764555d020622)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [4.2.6](https://www.github.com/googleapis/nodejs-language/compare/v4.2.5...v4.2.6) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#595](https://www.github.com/googleapis/nodejs-language/issues/595)) ([3ac3cfb](https://www.github.com/googleapis/nodejs-language/commit/3ac3cfb8d0ce0ba055502e07178764555d020622)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: Benjamin E. Coe <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://togithub.com/jsdoc/jsdoc) | [`^3.6.2` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://togithub.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#​400-November-2022) [Compare Source](https://togithub.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://togithub.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-iot). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9-->
Fixes #559
Apparently GitHub Pages redirects https://googlecloudplatform.github.io/gcloud-node to http://googlecloudplatform.github.io/gcloud-node/ (note the trailing
/
) so if we change our URLs to include the/
then it should remain on https.I've already changed the URL in our repo too: