-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample: update flaky dataproc sample and test to be more stable #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Sep 9, 2024
…/google-cloud-node into removeComplexDataproc
…/google-cloud-node into removeComplexDataproc
…/google-cloud-node into removeComplexDataproc
sofisl
changed the title
test: update flaky dataproc sample test to be more stable
sample: update flaky dataproc sample and test to be more stable
Sep 10, 2024
danielbankhead
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be OK given that the current dataproc sample actually resides here: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/HEAD/dataproc/quickstart.js (follow "view on github" from here: https://cloud.google.com/dataproc/docs/samples/dataproc-quickstart#dataproc_quickstart-nodejs)
Unblocks: #5654