Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Many APIs] improve retry logic for streaming API calls #4962

Merged
merged 6 commits into from
Jan 23, 2024
Merged

fix: [Many APIs] improve retry logic for streaming API calls #4962

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4aefe0
fix: improve retry logic for streaming API calls
gcf-owl-bot[bot] Jan 19, 2024
e0fdd8c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 19, 2024
e6eca35
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 19, 2024
6ac4446
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 19, 2024
ddd1bb4
Merge branch 'owl-bot-copy-c0a1e236cf9949638011' of https://github.co…
gcf-owl-bot[bot] Jan 19, 2024
b18130d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/google-cloud-apigeeconnect/src/v1/tether_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ export class TetherClient {
this.descriptors.stream = {
egress: new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.BIDI_STREAMING,
!!opts.fallback
!!opts.fallback,
/* gaxStreamingRetries: */ true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write in this way? Looks cleaner.

Suggested change
/* gaxStreamingRetries: */ true
true /* gaxStreamingRetries: */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tanvirstreame, this code is autogenerated from the generator (gapic-generator-typescript) and touches all APIs in the library. If you feel strongly, feel free to create an issue here: https://github.com/googleapis/gapic-generator-typescript

),
};

Expand Down