Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification_channels in aiplatform v1beta1 model_monitoring.proto #4160

Merged
merged 6 commits into from
Apr 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ option java_outer_classname = "ModelMonitoringProto";
option java_package = "com.google.cloud.aiplatform.v1beta1";
option php_namespace = "Google\\Cloud\\AIPlatform\\V1beta1";
option ruby_package = "Google::Cloud::AIPlatform::V1beta1";
option (google.api.resource_definition) = {
type: "monitoring.googleapis.com/NotificationChannel"
pattern: "projects/{project}/notificationChannels/{notification_channel}"
};

// The model monitoring configuration used for Batch Prediction Job.
message ModelMonitoringConfig {
Expand Down Expand Up @@ -208,6 +212,13 @@ message ModelMonitoringAlertConfig {
// This can be further sinked to Pub/Sub or any other services supported
// by Cloud Logging.
bool enable_logging = 2;

// Resource names of the NotificationChannels to send alert.
// Must be of the format
// `projects/<project_id_or_number>/notificationChannels/<channel_id>`
repeated string notification_channels = 3 [(google.api.resource_reference) = {
type: "monitoring.googleapis.com/NotificationChannel"
}];
}

// The config for feature monitoring threshold.
Expand Down
6 changes: 6 additions & 0 deletions packages/google-cloud-aiplatform/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 40 additions & 0 deletions packages/google-cloud-aiplatform/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions packages/google-cloud-aiplatform/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.