Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: reenable tests #3803

Merged
merged 9 commits into from
Dec 21, 2022
Merged

build: reenable tests #3803

merged 9 commits into from
Dec 21, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Dec 20, 2022

Fixes #3670

@sofisl sofisl requested a review from a team as a code owner December 20, 2022 16:49
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@sofisl sofisl merged commit 46b4330 into main Dec 21, 2022
@sofisl sofisl deleted the reenableTests branch December 21, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to reenable quickstart tests on 3 libraries that need SA key credentials
2 participants
@sofisl @bcoe