Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused values #2669

Merged
merged 2 commits into from
Oct 14, 2017
Merged

Remove unused values #2669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbcc3b8
Remove unused values
abetomo Oct 13, 2017
3a7b453
Remove unnecessary space
abetomo Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/error-reporting/src/google-apis/auth-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
'use strict';
const common = require('@google-cloud/common');
const pkg = require('../../package.json');
var logger = require('../logger.js');
var is = require('is');
var isFunction = is.fn;
var isString = is.string;
Expand Down Expand Up @@ -120,7 +119,7 @@ class RequestHandler extends common.Service {
method: 'POST',
json: {}
}, (err, body, response) => {
if (err && err.message !== 'Message cannot be empty.' &&
if (err && err.message !== 'Message cannot be empty.' &&
response.statusCode === 400) {
this._logger.error([
'Encountered an error while attempting to validate the provided',
Expand Down
4 changes: 0 additions & 4 deletions packages/error-reporting/utils/fuzzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ var maxBy = require('lodash.maxby');
var random = require('lodash.random');
var is = require('is');
var isNumber = is.number;
var isObject = is.object;
var isString = is.string;
var isArray = is.array;
var isNull = is.null;
var isFunction = is.function;

function Fuzzer() { }
Expand Down Expand Up @@ -202,7 +200,6 @@ Fuzzer.prototype.generate.object = function(numProperties, currentDepth, allowed

Fuzzer.prototype._backFillUnevenTypesArrays = function(argsTypesArray) {

var largestIndex = 0;
var largestLength = (maxBy(
argsTypesArray
, function(o) { return o.length }
Expand Down Expand Up @@ -292,7 +289,6 @@ Fuzzer.prototype._generateValuesForFuzzTyping = function(typesToFuzzOnEach, inde
Fuzzer.prototype.fuzzFunctionForTypes = function(fnToFuzz, expectsArgTypes, cb, withContext) {
var expectsArgTypesChecked = isArray(expectsArgTypes) ? expectsArgTypes : [];
var typesToFuzzOnEach = this._generateTypesToFuzzWith(expectsArgTypesChecked);
var withContextChecked = (withContext !== undefined) ? withContext : null;

var returnValue = undefined;

Expand Down