Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: tests: skip tests that CI does not have permissions for #2395

Merged
merged 1 commit into from
Jun 15, 2017
Merged

storage: tests: skip tests that CI does not have permissions for #2395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions packages/storage/system-test/storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var Bucket = Storage.Bucket;
var File = Storage.File;

describe('storage', function() {
var IS_CI = env.projectId === 'long-door-651';
var TESTS_PREFIX = 'gcloud-test-';

var storage = new Storage(env);
Expand All @@ -60,7 +61,7 @@ describe('storage', function() {
});

after(function(done) {
if (env.projectId === 'long-door-651') {
if (IS_CI) {
// The system tests account is unable to delete files.
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
done();
Expand Down Expand Up @@ -609,6 +610,12 @@ describe('storage', function() {

describe('bucket metadata', function() {
it('should allow setting metadata on a bucket', function(done) {
if (IS_CI) {
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
this.skip();
return;
}

var metadata = {
website: {
mainPageSuffix: 'http://fakeuri',
Expand All @@ -624,7 +631,8 @@ describe('storage', function() {
});
});

describe('write, read, and remove files', function() {
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
(IS_CI ? describe.skip : describe)('write/read/remove files', function() {
before(function(done) {
function setHash(filesKey, done) {
var file = FILES[filesKey];
Expand Down Expand Up @@ -1066,7 +1074,8 @@ describe('storage', function() {
});
});

describe('combine files', function() {
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
(IS_CI ? describe.skip : describe)('combine files', function() {
it('should combine multiple files into one', function(done) {
var files = [
{ file: bucket.file('file-one.txt'), contents: '123' },
Expand Down Expand Up @@ -1098,7 +1107,8 @@ describe('storage', function() {
});
});

describe('list files', function() {
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
(IS_CI ? describe.skip : describe)('list files', function() {
var NEW_FILES = [
bucket.file('CloudLogo1'),
bucket.file('CloudLogo2'),
Expand Down Expand Up @@ -1252,7 +1262,7 @@ describe('storage', function() {
});
});

describe('sign urls', function() {
(IS_CI ? describe.skip : describe)('sign urls', function() {
var localFile = fs.readFileSync(FILES.logo.path);
var file;

Expand Down Expand Up @@ -1300,7 +1310,8 @@ describe('storage', function() {
});
});

describe('sign policy', function() {
// RE: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2224
(IS_CI ? describe.skip : describe)('sign policy', function() {
var file;

before(function(done) {
Expand Down