Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue readme, replace non-existent method addRecord() with addRecords() #2339

Merged
merged 5 commits into from
Jun 2, 2017

Conversation

kinotto
Copy link
Contributor

@kinotto kinotto commented May 30, 2017

Hey guys, thanks for this library,

just reporting one issue in the cloud dns section of the readme

image

the example refers to a method addRecord() that is not available inside the zone object (even going up in the prototype chain)

the only method available is addRecords()

made some test locally and it seems to work fine.

image

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 30, 2017
@kinotto
Copy link
Contributor Author

kinotto commented May 30, 2017

I signed it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@kinotto
Copy link
Contributor Author

kinotto commented May 30, 2017

fixed email info for license agreement

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0163c79 on kinotto:fix_issue_readme into 0ef2737 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Thanks! Would you mind updating the DNS readme as well? packages/dns/readme.md

@stephenplusplus stephenplusplus added api: dns Issues related to the Cloud DNS API. docs labels May 30, 2017
@kinotto
Copy link
Contributor Author

kinotto commented May 30, 2017

sure. just did it 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aa2c6ad on kinotto:fix_issue_readme into 0ef2737 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Great, thank you!

I'll need some assistance from @swcloud to confirm the CLA is good.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a6fbc82 on kinotto:fix_issue_readme into 0ef2737 on GoogleCloudPlatform:master.

@swcloud swcloud removed the cla: no This human has *not* signed the Contributor License Agreement. label May 31, 2017
@swcloud
Copy link
Contributor

swcloud commented May 31, 2017

@stephenplusplus It should automatically remove 'cla:no' label once the user says 'I signed it', right?

@swcloud swcloud added the cla: no This human has *not* signed the Contributor License Agreement. label May 31, 2017
@stephenplusplus
Copy link
Contributor

It should, I think you just need to verify that this comment has been resolved: #2339 (comment)

@kinotto
Copy link
Contributor Author

kinotto commented Jun 1, 2017

i signed the CLA, but it keeps saying cla:no..probably it's related to the fact that i'm using a different email for github and for google CLA. i've even changed the commit email to match the CLA email but still no luck. can you help me out?

@swcloud
Copy link
Contributor

swcloud commented Jun 1, 2017

ok. I can manually remove 'cla:no' label.

@swcloud swcloud removed the cla: no This human has *not* signed the Contributor License Agreement. label Jun 1, 2017
@kinotto
Copy link
Contributor Author

kinotto commented Jun 1, 2017

Thank you @swcloud

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 1, 2017
@stephenplusplus
Copy link
Contributor

@swcloud I'll let you merge this one :)

@swcloud swcloud merged commit 4ab2875 into googleapis:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants