-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue readme, replace non-existent method addRecord() with addRecords() #2339
Conversation
…h addRecords()" This reverts commit 539ae0d.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
fixed email info for license agreement |
Thanks! Would you mind updating the DNS readme as well? packages/dns/readme.md |
sure. just did it 👍 |
Great, thank you! I'll need some assistance from @swcloud to confirm the CLA is good. |
@stephenplusplus It should automatically remove 'cla:no' label once the user says 'I signed it', right? |
It should, I think you just need to verify that this comment has been resolved: #2339 (comment) |
i signed the CLA, but it keeps saying cla:no..probably it's related to the fact that i'm using a different email for github and for google CLA. i've even changed the commit email to match the CLA email but still no luck. can you help me out? |
ok. I can manually remove 'cla:no' label. |
Thank you @swcloud |
@swcloud I'll let you merge this one :) |
Hey guys, thanks for this library,
just reporting one issue in the cloud dns section of the readme
the example refers to a method addRecord() that is not available inside the zone object (even going up in the prototype chain)
the only method available is addRecords()
made some test locally and it seems to work fine.