core: only recurse relevant request objects #2100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908
Previously, we took an input object that would go to
request
and iterated over all of the properties. This turned out to be an issue when the request object had properties containing circular references. What we really want to do is loop a select number of properties which may include the projectId token:reqOpts.qs
(an object which gets serialized into a query string)reqOpts.json
(the JSON payload)reqOpts.uri
(the URL the request is sent to, which always exists)