-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language: remove verbose option #2056
language: remove verbose option #2056
Conversation
@stephenplusplus before I go in and do it, my plan for the docs was to remove a lot of the params detailing the objects we return to the user in favor of just linking them to the upstream docs. Using WDYT? |
I think if we're returning the raw API response, linking is good. But, if we do any re-mapping, we have to document it. However, I think @jgeewax wanted to kill the grouping of types, which I think means we are only ever returning the raw API response. So, no special docs would be needed, if we do that. |
Got it, could you PTAL at my latest changes to see if what we'll now be providing in the callback looks ok? If so, I'm going to get started on tests and docs. |
LGTM. |
@stephenplusplus I think I'm done here if you would kindly take a look! |
return function(err, annotation, apiResponse) { | ||
try { | ||
assert.ifError(err); | ||
|
||
assert.strictEqual(annotation.language, 'en'); | ||
|
||
assert(is.object(annotation.sentiment)); | ||
assert(is.number(annotation.sentiment.score)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
All looks good to me, just the one thing about simplifying the system test checks now that we're just passing back the raw response. |
Closes #1782
TODOs