storage: fix credentials issue. #164

stephenplusplus · 2014-09-01T17:16:05Z

Previously, if a user wanted to generate a signed URL, there was no guarantee a credentials object would have already been generated. By itself, generating a signed URL doesn't require a network connection, thus the uncertainty that we would have already fetched a token. This change requires a valid credentials object to exist before returning the credentials object.

~~This also brings up an issue. We need to go through the code to catch any "maybe async, maybe not" functions, and add in a process.nextTick where necessary.~~ (#166)

lib/common/connection.js

+Connection.prototype.getCredentials = function(callback) {
+  var that = this;
+  if (this.credentials) {
+    process.nextTick(function() {


lib/common/connection.js

+  }
+  this.fetchToken(function(err) {
+    if (err) {
+      callback(err);


Previously, if a user wanted to generate a signed URL, there was no guarantee a credentials object would have already been generated. By itself, generating a signed URL doesn't require a network connection, thus the uncertainty that we would have already fetched a token. This change requires a valid credentials object to exist before returning the `credentials` object.

rakyll · 2014-09-05T19:08:04Z

Sorry, I'm not familiar with signed URLs. Is there anyone else to review it @silvolu, from Storage team?

stephenplusplus · 2014-09-05T19:14:21Z

Np, this is actually mostly an API change - adding the getCredentials method. There weren't actually any functionality changes to the signed URL functionality that we already have.

Currently, we wait until an API request to fetch a token, which makes sense. But to create a signed URL, we don't actually have to make an API call. So, we never get a credentials object (unless the user provided it themselves), which is why I added this method. It will return the credentials if they're available, otherwise it will go build it for us by making a fetchToken call.

lib/common/connection.js

@@ -95,9 +95,10 @@ module.exports.Token = Token;
 function Connection(opts) {
  events.EventEmitter.call(this);

-  this.opts = opts || {};
+  opts = opts || {};


storage: fix credentials issue.

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

@method

* build: check dead links on Kokoro * recursive crawl local links * annotate Project#exists with @method * npm run fix

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jsdoc](https://togithub.com/jsdoc/jsdoc) | [`^3.6.6` -> `^4.0.0`](https://renovatebot.com/diffs/npm/jsdoc/3.6.11/4.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/compatibility-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc/4.0.0/confidence-slim/3.6.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jsdoc/jsdoc</summary> ### [`v4.0.0`](https://togithub.com/jsdoc/jsdoc/blob/HEAD/CHANGES.md#400-November-2022) [Compare Source](https://togithub.com/jsdoc/jsdoc/compare/3.6.11...084218523a7d69fec14a852ce680f374f526af28) - JSDoc releases now use [semantic versioning](https://semver.org/). If JSDoc makes backwards-incompatible changes in the future, the major version will be incremented. - JSDoc no longer uses the [`taffydb`](https://taffydb.com/) package. If your JSDoc template or plugin uses the `taffydb` package, see the [instructions for replacing `taffydb` with `@jsdoc/salty`](https://togithub.com/jsdoc/jsdoc/tree/main/packages/jsdoc-salty#use-salty-in-a-jsdoc-template). - JSDoc now supports Node.js 12.0.0 and later. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-contact-center-insights).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 434859890 Source-Link: googleapis/googleapis@bc2432d Source-Link: googleapis/googleapis-gen@930b673 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets Source-Link: googleapis/synthtool@be74d3e

🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.4](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.7.3...v1.7.4) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#164](https://www.github.com/googleapis/nodejs-ai-platform/issues/164)) ([1ec11fc](https://www.github.com/googleapis/nodejs-ai-platform/commit/1ec11fc4fac373ee1a28ac10676fbfe9fc5535d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

rakyll reviewed Sep 2, 2014
View reviewed changes

stephenplusplus force-pushed the connection branch from 15484d5 to 0de5a0d Compare September 2, 2014 19:14

ryanseys reviewed Sep 2, 2014
View reviewed changes

lib/common/connection.js

}

this.fetchToken(function(err) {

if (err) {

callback(err);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the connection branch 2 times, most recently from c47c526 to 25a6b06 Compare September 2, 2014 22:34

stephenplusplus force-pushed the connection branch from 25a6b06 to bb4cd17 Compare September 4, 2014 15:37

silvolu reviewed Sep 8, 2014
View reviewed changes

stephenplusplus mentioned this pull request Sep 8, 2014

bucket.getSignedUrl code in docs didn't work #195

Closed

silvolu added a commit that referenced this pull request Sep 8, 2014

Merge pull request #164 from stephenplusplus/connection

bd3f976

storage: fix credentials issue.

silvolu merged commit bd3f976 into googleapis:master Sep 8, 2014

snyk-bot mentioned this pull request May 21, 2020

[Snyk] Upgrade google-proto-files from 0.1.1 to 0.20.0 aknuds1/gcloud-node#1

Open

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

chore: release 1.1.2 (#164)

38f3e50

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

fix: DEADLINE_EXCEEDED retry code is idempotent (#164)

ea6d04a

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-bigquery-data-transfer #3399

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022

docs: update contributing path in README (#164)

567f503

sofisl pushed a commit that referenced this pull request Oct 12, 2022

build: check broken links in generated docs (#164)

7868b85

* build: check dead links on Kokoro * recursive crawl local links * annotate Project#exists with @method * npm run fix

sofisl mentioned this pull request Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

chore(deps): update dependency linkinator to v4 (#164)

9dba218

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-bigquery-reservation #3413

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs: update contributing path in README (#164)

c387303

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

refactor: modernize the sample tests (#164)

c33d3fc

sofisl pushed a commit that referenced this pull request Nov 10, 2022

docs: fix example comments (#164)

5016055

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

feat: add the v1beta2 API (#164)

a82c1f0

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dataproc #3533

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-dataproc-metastore #3580

Merged

migrate code from googleapis/nodejs-contact-center-insights #3584

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-analytics-admin #3600

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow-cx #3602

Merged

4 tasks

sofisl added a commit that referenced this pull request Nov 11, 2022

fix(build): migrate to using main branch (#164)

e3ce6bc

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-appengine-admin #3607

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

fix(deps): use google-gax v3.5.2 (#164)

d8a5b6d

release-please bot mentioned this pull request Nov 12, 2022

chore: release main #3529

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 16, 2022

chore: run fix instead of lint in synthfile (#164)

1cb0dc2

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 24, 2023

Update CI config (#164)

395bd29

sofisl pushed a commit that referenced this pull request Jan 25, 2023

Update CI config (#164)

3d92480

sofisl pushed a commit that referenced this pull request Jan 26, 2023

fix(deps): google-gax v2.17.1 (#164)

7cfc611

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore: re-order template utils (#164)

47430ab

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: drop contributors from multiple places (#164)

610eca7

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

enterstudio mentioned this pull request Nov 28, 2023

[Snyk] Fix for 8 vulnerabilities enterstudio/google-cloud-node#161

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: fix credentials issue. #164

storage: fix credentials issue. #164

stephenplusplus commented Sep 1, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

storage: fix credentials issue. #164

storage: fix credentials issue. #164

Conversation

stephenplusplus commented Sep 1, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Sep 5, 2014

stephenplusplus commented Sep 5, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.