Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using custom domain name when creating signed resources #1408

Closed
wants to merge 2 commits into from

Conversation

AVVS
Copy link
Contributor

@AVVS AVVS commented Jul 3, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 3, 2016
@AVVS
Copy link
Contributor Author

AVVS commented Jul 3, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 3, 2016
@jgeewax
Copy link
Contributor

jgeewax commented Jul 4, 2016

Thanks @AVVS ! Looks like there's some trailing whitespace and a line over 80 characters, but if those are fixed this LGTM!

@coveralls
Copy link

coveralls commented Jul 4, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 007a9c5 on AVVS:patch-1 into 24810b9 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

Thanks, @AVVS! I made a few trivial changes and merged them in via 0a6da60

@stephenplusplus stephenplusplus added the api: storage Issues related to the Cloud Storage API. label Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants