Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Through2 needs callback #963

Closed
afanasy opened this issue Nov 25, 2015 · 2 comments
Closed

Through2 needs callback #963

afanasy opened this issue Nov 25, 2015 · 2 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API.

Comments

@afanasy
Copy link
Contributor

afanasy commented Nov 25, 2015

https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.25.1/bigquery/job

In this example, through2.obj needs the callback call?

var through2 = require('through2');
var fs = require('fs');

job.getQueryResults()
  .pipe(through2.obj(function (row, enc, next) {
    this.push(JSON.stringify(row) + '\n');
//next(); is missing from docs
  }))
  .pipe(fs.createWriteStream('./test/testdata/testfile.json'));
@stephenplusplus
Copy link
Contributor

Good catch! Any chance you're free to do a PR?

@stephenplusplus stephenplusplus added docs api: bigquery Issues related to the BigQuery API. labels Nov 25, 2015
afanasy added a commit to afanasy/gcloud-node that referenced this issue Nov 25, 2015
@stephenplusplus
Copy link
Contributor

Fixed by #964

sofisl pushed a commit that referenced this issue Nov 11, 2022
* chore(main): release 5.1.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

No branches or pull requests

2 participants