Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'auto_insert_id' in documentation should be 'insert_auto_id' #883

Closed
MMMMasterM opened this issue Sep 22, 2015 · 1 comment
Closed

'auto_insert_id' in documentation should be 'insert_auto_id' #883

MMMMasterM opened this issue Sep 22, 2015 · 1 comment
Assignees
@yoshi-automation
Labels
api: datastore Issues related to the Datastore API.

Comments

@MMMMasterM
Copy link

The documentation as well as a comment in the source files list 'auto_insert_id' as last insert method for the datastore, however checking the source revealed that it should be 'insert_auto_id'.
Also specifying an invalid method (e.g. 'auto_insert_id') does not report any error in the callback and doesn't throw which made finding the error harder than necessary.

Please fix the documentation and change the lib to report an error or throw when an invalid datastore insert/save method is specified.
@stephenplusplus stephenplusplus added enhancement api: datastore Issues related to the Datastore API. labels Sep 22, 2015
@stephenplusplus
Copy link
Contributor

You got it. Thanks for catching this!

@stephenplusplus stephenplusplus mentioned this issue Sep 22, 2015
Merged
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@gcf-owl-bot
fix: update proto definitions (#883)
7dcf347 
fix: update proto definitions


Source-Link: googleapis/synthtool@0a68e56
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this issue Nov 10, 2022
Merged
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@b-loved-dreamer
docs(samples): adds new list training sample (#883)
7b6335f
sofisl pushed a commit that referenced this issue Jan 24, 2023
@release-please
chore(main): release 4.10.2 (#883)
1aeb871 
🤖 I have created a release *beep* *boop*
---


### [4.10.2](googleapis/nodejs-speech@v4.10.1...v4.10.2) (2022-05-02)


### Bug Fixes

* flaky system test ([#882](googleapis/nodejs-speech#882)) ([e837b64](googleapis/nodejs-speech@e837b64))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Jan 25, 2023
@release-please
chore(main): release 4.10.2 (#883)
150f2a9 
🤖 I have created a release *beep* *boop*
---


### [4.10.2](googleapis/nodejs-speech@v4.10.1...v4.10.2) (2022-05-02)


### Bug Fixes

* flaky system test ([#882](googleapis/nodejs-speech#882)) ([e837b64](googleapis/nodejs-speech@e837b64))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenplusplus @MMMMasterM @yoshi-automation