-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small tweak to bucket names in Cloud Storage API code snippet (readme.md) #709
Comments
👍 |
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 10, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 17, 2022
Source-Link: googleapis/googleapis@68ad73b Source-Link: googleapis/googleapis-gen@a581672 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU4MTY3MjA2MWI5NDgxYzAxOTJkZTAzYmJmYTM0NjRlMDIzMzgxMSJ9 See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this issue
Jan 24, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the following code, there is potential for slight confusion, due to the similarity in bucket names:
// Create a new bucket.
gcs.createBucket('my-new-bucket', function(err, bucket) {});
// Reference an existing bucket.
var bucket = gcs.bucket('my-bucket');
I would suggest updating the snippet to something like:
gcs.createBucket('my-new-bucket', function(err, bucket) {
//do something with your bucket, or deal with the error
});
// Reference an existing bucket.
var bucket = gcs.bucket('an-existing-bucket');
The text was updated successfully, but these errors were encountered: