-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createTopic vs topic can be confusing? #669
Labels
api: pubsub
Issues related to the Pub/Sub API.
Comments
I like privatizing createTopic and autocreating by default. RE: "(why create a topic to not use it...?)", should we loop in a Pub/Sub-er to see if we should continue to support that? |
Hmm -- I think we're still pretty early, so it's not crazy to deprecate the method, and the "full deprecation" being that it's not longer in the docs. Thoughts? |
SGTM. |
3 tasks
4 tasks
sofisl
pushed a commit
that referenced
this issue
Sep 27, 2022
…andwritten libraries (#669) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
sofisl
pushed a commit
that referenced
this issue
Nov 9, 2022
…andwritten libraries (#669) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
4 tasks
Merged
sofisl
pushed a commit
that referenced
this issue
Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this issue
Jan 10, 2023
sofisl
pushed a commit
that referenced
this issue
Jan 24, 2023
Regenerated the library using [gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript) v1.2.1.
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
Regenerated the library using [gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript) v1.2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, to "create a topic", people jump immediately to
createTopic
-- which gives them back a topic, but then the second time they try to create a topic, it'll cause problems, right? What people typically want in their code istopic()
with{autoCreate: true}
...So... a couple options
createTopic
(why create a topic to not use it...?)createTopic
that you probably wanttopic()
topic()
's options to auto-create by defaultThoughts?
The text was updated successfully, but these errors were encountered: