Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createTopic vs topic can be confusing? #669

Closed
jgeewax opened this issue Jun 17, 2015 · 3 comments · Fixed by #685
Closed

createTopic vs topic can be confusing? #669

jgeewax opened this issue Jun 17, 2015 · 3 comments · Fixed by #685
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Jun 17, 2015

Right now, to "create a topic", people jump immediately to createTopic -- which gives them back a topic, but then the second time they try to create a topic, it'll cause problems, right? What people typically want in their code is topic() with {autoCreate: true} ...

So... a couple options

  1. Remove / privatize createTopic (why create a topic to not use it...?)
  2. Document in createTopic that you probably want topic()
    1. and update topic()'s options to auto-create by default

Thoughts?

@jgeewax jgeewax added docs api: pubsub Issues related to the Pub/Sub API. labels Jun 17, 2015
@stephenplusplus
Copy link
Contributor

I like privatizing createTopic and autocreating by default. RE: "(why create a topic to not use it...?)", should we loop in a Pub/Sub-er to see if we should continue to support that?

@jgeewax
Copy link
Contributor Author

jgeewax commented Jun 22, 2015

Hmm -- I think we're still pretty early, so it's not crazy to deprecate the method, and the "full deprecation" being that it's not longer in the docs. Thoughts?

@stephenplusplus
Copy link
Contributor

SGTM.

@stephenplusplus stephenplusplus self-assigned this Jun 22, 2015
sofisl pushed a commit that referenced this issue Sep 27, 2022
…andwritten libraries (#669)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
sofisl pushed a commit that referenced this issue Nov 9, 2022
…andwritten libraries (#669)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 429395631

Source-Link: googleapis/googleapis@84594b3

Source-Link: googleapis/googleapis-gen@ed74f97
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9
sofisl pushed a commit that referenced this issue Nov 11, 2022
sofisl pushed a commit that referenced this issue Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Jan 24, 2023
sofisl pushed a commit that referenced this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants