-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict API call query parameters to what we say we accept #653
Comments
Interesting idea, I've explored a similar idea before in |
Okay, let's do it the way we're doing it. 👍 Will close, anyone feel free to re-open if there's a better solution than "nevermind" :) |
PiperOrigin-RevId: 322420178 Source-Author: Google APIs <[email protected]> Source-Date: Tue Jul 21 12:43:47 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: be0c5a9b1b88ca3bb8ad993ae7b2e6affde7fee2 Source-Link: googleapis/googleapis@be0c5a9 Co-authored-by: sofisl <[email protected]>
🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.1](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.1.0...v3.1.1) (2020-07-23) ### Bug Fixes * publish missing client config annotations ([#653](https://www.github.com/googleapis/nodejs-dialogflow/issues/653)) ([b368797](https://www.github.com/googleapis/nodejs-dialogflow/commit/b36879723fd3aeab0c158d3ab76a5aa6505498e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5c526dd9-97ec-4177-a349-428900ed8fb2/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@079dcce
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5c526dd9-97ec-4177-a349-428900ed8fb2/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@079dcce
Related: #647, #652
Right now, we sometimes kind of blindly pass the user's provided object to the API. We should be sure to only pass through what we say in our docs we accept.
I'm thinking something like:
The text was updated successfully, but these errors were encountered: