Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions #605

Closed
ryanseys opened this issue May 17, 2015 · 4 comments · Fixed by #618
Closed

Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions #605

ryanseys opened this issue May 17, 2015 · 4 comments · Fixed by #618
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@ryanseys
Copy link
Contributor

Add pubsub#subscription and pubsub#subscribe and pubsub#getSubscriptions.

All the logic I feel should move to these requests and then topic#subscription and topic#subscribe and topic#getSubscriptions should either be removed or rely on the pubsub version with an optional topic field automatically passed in.

How's this sound @stephenplusplus?

Reference: #487

/cc @tmatsuo

@ryanseys ryanseys added api: pubsub Issues related to the Pub/Sub API. enhancement labels May 17, 2015
@ryanseys ryanseys changed the title Add pubsub#subscription and pubsub#subscribe Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions May 17, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 18, 2015

Can we clarify the use case on this ? #487 is long, so it'd be nice if the description said "why" we're doing this.

I have one outstanding question, which if answered, makes me OK with these new pubsub-level methods. I also would agree that if we do add these, the topic-level ones simply wrap the pubsub-level ones. That is:

Topic.prototype.subscribe = function(...) {
  return this.path.to.pubsubInstance.subscribe(...);
};

@ryanseys
Copy link
Contributor Author

The use case is for creating a subscription in one project that subscribes to a topic in another project.

@stephenplusplus
Copy link
Contributor

@ryanseys SGTM. In fact, I can start working on this now, but feel free to stop me if you already had this in the works.

@ryanseys
Copy link
Contributor Author

@stephenplusplus You can go for it!

chingor13 pushed a commit that referenced this issue Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this issue Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this issue Aug 22, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Jan 24, 2023
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/8d5e906d-0de4-4e28-b374-7d5fd4a1ce62/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077
sofisl pushed a commit that referenced this issue Jan 25, 2023
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/8d5e906d-0de4-4e28-b374-7d5fd4a1ce62/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants