-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pubsub#subscription, pubsub#subscribe and pubsub#getSubscriptions #605
Comments
Can we clarify the use case on this ? #487 is long, so it'd be nice if the description said "why" we're doing this. I have one outstanding question, which if answered, makes me OK with these new pubsub-level methods. I also would agree that if we do add these, the topic-level ones simply wrap the pubsub-level ones. That is: Topic.prototype.subscribe = function(...) {
return this.path.to.pubsubInstance.subscribe(...);
}; |
The use case is for creating a subscription in one project that subscribes to a topic in another project. |
@ryanseys SGTM. In fact, I can start working on this now, but feel free to stop me if you already had this in the works. |
@stephenplusplus You can go for it! |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8d5e906d-0de4-4e28-b374-7d5fd4a1ce62/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@1c92077
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/8d5e906d-0de4-4e28-b374-7d5fd4a1ce62/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@1c92077
Add
pubsub#subscription
andpubsub#subscribe
andpubsub#getSubscriptions
.All the logic I feel should move to these requests and then
topic#subscription
andtopic#subscribe
andtopic#getSubscriptions
should either be removed or rely on the pubsub version with an optionaltopic
field automatically passed in.How's this sound @stephenplusplus?
Reference: #487
/cc @tmatsuo
The text was updated successfully, but these errors were encountered: