Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore#dataset is ignored in documentation? #547

Closed
jgeewax opened this issue May 8, 2015 · 1 comment · Fixed by #581 or #584
Closed

datastore#dataset is ignored in documentation? #547

jgeewax opened this issue May 8, 2015 · 1 comment · Fixed by #581 or #584
Assignees
@yoshi-automation
Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.
Milestone
Datastore Future

Comments

@jgeewax
Copy link
Contributor

jgeewax commented May 8, 2015

Looking at https://github.com/GoogleCloudPlatform/gcloud-node/blob/1f57dd607b4c52a48f88781cd185220d40683184/lib/datastore/index.js#L94

Looks like we chose to make this "Developer documentation"?

Seems weird that we'd have pubsub#topic documented but not datastore#dataset? (http://googlecloudplatform.github.io/gcloud-node/#/docs/master/pubsub?method=topic)

Was there a reason we chose to ! ignore that docstring?
@jgeewax jgeewax added type: question Request for information or clarification. Not an issue. docs api: datastore Issues related to the Datastore API. labels May 8, 2015
@jgeewax jgeewax added this to the Datastore Future milestone May 8, 2015
@stephenplusplus
Copy link
Contributor

I think it may have been a mistake. Sometimes a Developer doc block is stacked on top of a public doc block, so maybe a sloppy delete left the /*! Developer Documentation heading instead of the other. Good find, will fix!

stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue May 11, 2015
@stephenplusplus
docs: publicly document Datastore.dataset - fixes googleapis#547
811b6c9
@stephenplusplus stephenplusplus mentioned this issue May 11, 2015
Merged
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue May 11, 2015
@stephenplusplus
docs: fix broken code links - fixes googleapis#547
56bc620
@stephenplusplus stephenplusplus mentioned this issue May 11, 2015
Merged
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue May 11, 2015
@stephenplusplus
docs: fix broken code links - fixes googleapis#547
5838e10
ryanseys added a commit that referenced this issue May 12, 2015
@ryanseys
Merge pull request #581 from stephenplusplus/spp--docs-datastore-data…
6da3e50 
…set-ignored

docs: publicly document Datastore.dataset - fixes #547
ryanseys added a commit that referenced this issue May 12, 2015
@ryanseys
Merge pull request #584 from stephenplusplus/spp--docs-link-to-code-bug
c1f135f 
docs: fix broken code links - fixes #547
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@peter-zheng-g @bcoe @sofisl
build: make quickstart sample tests more stable (#547)
427923f 
* CloudAsset: Update asset lib to v1 for ListAssets sample code

* CloudAsset: Fix flakiness of test of BatchGetAssetsHistory sample code

* CloudAsset: Remove unneeded output line in sample test

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: sofisl <[email protected]>
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@peter-zheng-g @bcoe @sofisl
build: make quickstart sample tests more stable (#547)
0c670d8 
* CloudAsset: Update asset lib to v1 for ListAssets sample code

* CloudAsset: Fix flakiness of test of BatchGetAssetsHistory sample code

* CloudAsset: Remove unneeded output line in sample test

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: sofisl <[email protected]>
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@peter-zheng-g @bcoe @sofisl
build: make quickstart sample tests more stable (#547)
786791c 
* CloudAsset: Update asset lib to v1 for ListAssets sample code

* CloudAsset: Fix flakiness of test of BatchGetAssetsHistory sample code

* CloudAsset: Remove unneeded output line in sample test

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: sofisl <[email protected]>
@sofisl sofisl mentioned this issue Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 16, 2022
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#547)
9f36164 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl pushed a commit that referenced this issue Sep 27, 2022
@morgandu @gcf-owl-bot
samples: add streaming_automl_object_tracking sample (#547)
7275ff8 
* samples: add streaming_automl_object_tracking sample

* fix: skip checking doc link before merged

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#547)
239962d 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
@sofisl sofisl mentioned this issue Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#547)
9a27f43 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
@sofisl sofisl mentioned this issue Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 8, 2022
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#547)
ff7307d 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
This was referenced Oct 11, 2022
Closed
Closed
Closed
This was referenced Oct 12, 2022
Closed
Closed
Closed
sofisl pushed a commit that referenced this issue Nov 9, 2022
@morgandu @gcf-owl-bot
samples: add streaming_automl_object_tracking sample (#547)
81b55f4 
* samples: add streaming_automl_object_tracking sample

* fix: skip checking doc link before merged

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 9, 2022
Closed
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 10, 2022
@yoshi-automation
fix: handle fallback option properly (#547)
e007050 
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore(nodejs_templates): add script logging to node_library populate-secrets.sh

Co-authored-by: Benjamin E. Coe <[email protected]>

Source-Author: BenWhitehead <[email protected]>
Source-Date: Wed Jun 10 22:24:28 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: e7034945fbdc0e79d3c57f6e299e5c90b0f11469
Source-Link: googleapis/synthtool@e703494
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@release-please
chore: release 2.3.5 (#547)
653f940 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.5](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.4...v2.3.5) (2021-07-12)


### Bug Fixes

* **deps:** google-gax v2.17.1 ([#546](https://www.github.com/googleapis/nodejs-tasks/issues/546)) ([dafe1b6](https://www.github.com/googleapis/nodejs-tasks/commit/dafe1b6cbf94fddc3fc4f5ac47eecf59e8173317))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 3.2.0 (#547)
32e5fe5 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.2.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.1.0...v3.2.0) (2021-10-19)


### Features

* Add support for dataproc BatchController service ([#546](https://www.github.com/googleapis/nodejs-dataproc/issues/546)) ([cfc0eeb](https://www.github.com/googleapis/nodejs-dataproc/commit/cfc0eeba2e614b271aae246acde8200f080a6ccb))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@summer-ji-eng @alexander-fenster
chore: correct .jsdoc.js protos and double quotes (#547)
80705af 
* chore: update jsdoc - protos and double quote

* chore: update jsdoc - protos and double quote

* Update package.json

Co-authored-by: Alexander Fenster <[email protected]>
sofisl added a commit that referenced this issue Nov 11, 2022
@peter-zheng-g @bcoe @sofisl
build: make quickstart sample tests more stable (#547)
b04098e 
* CloudAsset: Update asset lib to v1 for ListAssets sample code

* CloudAsset: Fix flakiness of test of BatchGetAssetsHistory sample code

* CloudAsset: Remove unneeded output line in sample test

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: sofisl <[email protected]>
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore(main): release 2.11.1 (#547)
5106069 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@yoshi-automation
fix: retrieve job config for risk analysis jobs; docs: clarify timesp…
674daea 
…an config for BigQuery and Datastore. (#547)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a671744d-65a2-494c-b4b1-d70a1bf407e2/targets

- [ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 336694775
Source-Link: googleapis/googleapis@795f0ca
@sofisl sofisl mentioned this issue Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 17, 2023
@alexander-fenster
feat: export protos from src/index.ts (#547)
14865a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: datastore Issues related to the Datastore API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
Datastore Future
3 participants
@jgeewax @stephenplusplus @yoshi-automation