Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is gcloud-node going to work with iojs? #380

Closed
jgeewax opened this issue Feb 3, 2015 · 6 comments · Fixed by #386
Closed

Is gcloud-node going to work with iojs? #380

jgeewax opened this issue Feb 3, 2015 · 6 comments · Fixed by #386
Assignees
Labels
core type: question Request for information or clarification. Not an issue.
Milestone

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Feb 3, 2015

Maybe we should add some tests to make sure our build passes using the iojs.org runtime? Not sure if it's worthwhile, but figured I'd toss this out.

@jgeewax jgeewax added type: question Request for information or clarification. Not an issue. core testing labels Feb 3, 2015
@jgeewax jgeewax added this to the Core Future milestone Feb 3, 2015
@ryanseys
Copy link
Contributor

ryanseys commented Feb 4, 2015

Once travis lands with iojs support (which was supposed to be today but has been rolled back for now) then I say we set up travis to run tests on it, but under allow_failures this way we can phase it in without committing to it entirely.

@ryanseys
Copy link
Contributor

ryanseys commented Feb 4, 2015

For the record, right now 100% of unit tests and 100% of regression tests pass on io.js v1.0.4

@ryanseys
Copy link
Contributor

ryanseys commented Feb 5, 2015

npm install fails though due to a dependency build issue with sse4_crc32 (issue filed here)

@ryanseys
Copy link
Contributor

ryanseys commented Feb 5, 2015

Actually I am mistaken, it does not fail totally per se because sse4_crc32 which is used by our dependency fast-crc32c is actually an optional dependency.

@mstade
Copy link

mstade commented Feb 8, 2015

Travis just recently announced iojs support. I'd make a PR but it's too much of a hassle (and I'm weary of) signing your CLA so I won't, my apologies.

@ryanseys
Copy link
Contributor

ryanseys commented Feb 8, 2015

Added to #386

chingor13 pushed a commit that referenced this issue Aug 22, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/c36c6dbc-ab79-4f17-b70b-523b420b2a70/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this issue Sep 15, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^6.2.1` -> `^7.0.0`](https://renovatebot.com/diffs/npm/ts-loader/6.2.2/7.0.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-loader</summary>

### [`v7.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v700)

[Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v6.2.2...v7.0.0)

-   [Project reference support enhancements](https://togithub.com/TypeStrong/ts-loader/pull/1076) - thanks [@&#8203;sheetalkamat](https://togithub.com/sheetalkamat)!
-   Following the end of life of Node 8, `ts-loader` no longer supports Node 8 **BREAKING CHANGE**

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-redis).
sofisl pushed a commit that referenced this issue Sep 16, 2022
…380)

Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Wed Aug 26 14:28:22 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9
Source-Link: googleapis/synthtool@8cf6d28
sofisl pushed a commit that referenced this issue Oct 5, 2022
…380)

Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Wed Aug 26 14:28:22 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9
Source-Link: googleapis/synthtool@8cf6d28
sofisl pushed a commit that referenced this issue Oct 5, 2022
…380)

Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Wed Aug 26 14:28:22 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9
Source-Link: googleapis/synthtool@8cf6d28
sofisl pushed a commit that referenced this issue Oct 8, 2022
…380)

Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Wed Aug 26 14:28:22 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9
Source-Link: googleapis/synthtool@8cf6d28
sofisl pushed a commit that referenced this issue Oct 13, 2022
#380)

* build(node): add feat in node post-processor to add client library version number in snippet metadata

Co-authored-by: Benjamin E. Coe <[email protected]>
Source-Link: googleapis/synthtool@d337b88
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d106724ad2a96daa1b8d88de101ba50bdb30b8df62ffa0aa2b451d93b4556641
sofisl pushed a commit that referenced this issue Nov 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@google-cloud/storage](https://togithub.com/googleapis/nodejs-storage) | dependencies | major | [`^4.1.3` -> `^5.0.0`](https://renovatebot.com/diffs/npm/@google-cloud%2fstorage/4.7.0/5.0.0) |

---

### Release Notes

<details>
<summary>googleapis/nodejs-storage</summary>

### [`v5.0.0`](https://togithub.com/googleapis/nodejs-storage/blob/master/CHANGELOG.md#&#8203;500-httpswwwgithubcomgoogleapisnodejs-storagecomparev470v500-2020-05-13)

[Compare Source](https://togithub.com/googleapis/nodejs-storage/compare/v4.7.0...v5.0.0)

##### ⚠ BREAKING CHANGES

-   automatically detect contentType if not provided ([#&#8203;1190](https://togithub.com/googleapis/nodejs-storage/issues/1190))
-   drop keepAcl parameter in file copy ([#&#8203;1166](https://togithub.com/googleapis/nodejs-storage/issues/1166))
-   drop support for node.js 8.x

##### Features

-   automatically detect contentType if not provided ([#&#8203;1190](https://www.github.com/googleapis/nodejs-storage/issues/1190)) ([b31ba4a](https://www.github.com/googleapis/nodejs-storage/commit/b31ba4a11399b57538ddf0d6ca2e10b2aa3fbc3a))
-   enable bytes read tracking ([#&#8203;1074](https://www.github.com/googleapis/nodejs-storage/issues/1074)) ([0776a04](https://www.github.com/googleapis/nodejs-storage/commit/0776a044f3b2149b485e114369e952688df75645))

##### Bug Fixes

-   **bucket:** Only disable resumable uploads for bucket.upload (fixes [#&#8203;1133](https://www.github.com/googleapis/nodejs-storage/issues/1133)) ([#&#8203;1135](https://www.github.com/googleapis/nodejs-storage/issues/1135)) ([2c20148](https://www.github.com/googleapis/nodejs-storage/commit/2c201486b7b2d3146846ac96c877a904c4a674b0)), closes [/github.com/googleapis/nodejs-storage/pull/1135#issuecomment-620070038](https://www.github.com/googleapis//github.com/googleapis/nodejs-storage/pull/1135/issues/issuecomment-620070038)
-   add whitespace to generateV4SignedPolicy ([#&#8203;1136](https://www.github.com/googleapis/nodejs-storage/issues/1136)) ([dcee78b](https://www.github.com/googleapis/nodejs-storage/commit/dcee78b98da23b02fe7d2f13a9270546bc07bba8))
-   apache license URL ([#&#8203;468](https://www.github.com/googleapis/nodejs-storage/issues/468)) ([#&#8203;1151](https://www.github.com/googleapis/nodejs-storage/issues/1151)) ([e8116d3](https://www.github.com/googleapis/nodejs-storage/commit/e8116d3c6fa7412858692e67745b514eef78850e))
-   Point to team in correct org ([#&#8203;1185](https://www.github.com/googleapis/nodejs-storage/issues/1185)) ([0bb1909](https://www.github.com/googleapis/nodejs-storage/commit/0bb19098013acf71cc3842f78ff333a8e356331a))
-   **deps:** update dependency [@&#8203;google-cloud/common](https://togithub.com/google-cloud/common) to v3 ([#&#8203;1134](https://www.github.com/googleapis/nodejs-storage/issues/1134)) ([774ac5c](https://www.github.com/googleapis/nodejs-storage/commit/774ac5c75f02238418cc8ed7242297ea573ca9cb))
-   **deps:** update dependency [@&#8203;google-cloud/paginator](https://togithub.com/google-cloud/paginator) to v3 ([#&#8203;1131](https://www.github.com/googleapis/nodejs-storage/issues/1131)) ([c1614d9](https://www.github.com/googleapis/nodejs-storage/commit/c1614d98e3047db379e09299b1014e80d73ed52f))
-   **deps:** update dependency [@&#8203;google-cloud/promisify](https://togithub.com/google-cloud/promisify) to v2 ([#&#8203;1127](https://www.github.com/googleapis/nodejs-storage/issues/1127)) ([06624a5](https://www.github.com/googleapis/nodejs-storage/commit/06624a534cd1fdbc38455eee8d89f9f60ba75758))
-   **deps:** update dependency uuid to v8 ([#&#8203;1170](https://www.github.com/googleapis/nodejs-storage/issues/1170)) ([6a98d64](https://www.github.com/googleapis/nodejs-storage/commit/6a98d64831baf1ca1ec2f03ecc4914745cba1c86))
-   **deps:** update gcs-resumable-upload, remove gitnpm usage ([#&#8203;1186](https://www.github.com/googleapis/nodejs-storage/issues/1186)) ([c78c9cd](https://www.github.com/googleapis/nodejs-storage/commit/c78c9cde49dccb2fcd4ce10e4e9f8299d65f6838))
-   **v4-policy:** encode special characters ([#&#8203;1169](https://www.github.com/googleapis/nodejs-storage/issues/1169)) ([6e48539](https://www.github.com/googleapis/nodejs-storage/commit/6e48539d76ca27e6f4c6cf2ac0872970f7391fed))
-   sync to [googleapis/conformance-tests@`fa559a1`](https://togithub.com/googleapis/conformance-tests/commit/fa559a1) ([#&#8203;1167](https://www.github.com/googleapis/nodejs-storage/issues/1167)) ([5500446](https://www.github.com/googleapis/nodejs-storage/commit/550044619d2f17a1977c83bce5df915c6dc9578c)), closes [#&#8203;1168](https://www.github.com/googleapis/nodejs-storage/issues/1168)

##### Miscellaneous Chores

-   drop keepAcl parameter in file copy ([#&#8203;1166](https://www.github.com/googleapis/nodejs-storage/issues/1166)) ([5a4044a](https://www.github.com/googleapis/nodejs-storage/commit/5a4044a8ba13f248fc4f791248f797eb0f1f3c16))

##### Build System

-   drop support for node.js 8.x ([b80c025](https://www.github.com/googleapis/nodejs-storage/commit/b80c025f106052fd25554c64314b3b3520e829b5))

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dataproc).
sofisl pushed a commit that referenced this issue Nov 11, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@05de3e1
sofisl pushed a commit that referenced this issue Nov 11, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/c36c6dbc-ab79-4f17-b70b-523b420b2a70/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this issue Nov 16, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 30, 2022
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl pushed a commit that referenced this issue Jan 17, 2023
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
sofisl pushed a commit that referenced this issue Sep 13, 2023
sofisl pushed a commit that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants