Datastore client not getting ProjectID from env

[thesandlord]

It looks like Datastore client is not getting the projectID from the env automatically.

var pubsub = gcloud.pubsub();

This works fine, but:

var dataset = gcloud.datastore.dataset();

returns:

Error: Sorry, we cannot connect to Google Cloud Services without a project ID. You may specify one with an environment variable named "GCLOUD_PROJECT". See https://googlecloudplatform.github.io/gcloud-node/#/authentication for a detailed guide on creating an authenticated connection.

This fixes the problem

var dataset = gcloud.datastore.dataset({projectId: process.env.GCLOUD_PROJECT});

[stephenplusplus]

Good catch, thanks for letting us know. PR incoming!

[thesandlord]

im not sure if other clients also have this problem. I though they all extend the same base class?

[stephenplusplus]

I checked, all of the other APIs do it.

@callmehiphop can you think of a way we can move the normalizing to the Service constructor?

[callmehiphop]

@stephenplusplus we should be able to just normalize them in the Service constructor, no?

[stephenplusplus]

I think there might be an issue with double-instantion?

On Thu, Jan 28, 2016, 11:01 AM Dave Gramlich [email protected]
wrote:

@stephenplusplus https://github.com/stephenplusplus we should be able
to just normalize them in the Service constructor, no?

—
Reply to this email directly or view it on GitHub
#1092 (comment)
.

[callmehiphop]

Service.call(...) only gets called once IIRC - after a service class has been instantiated.. right?

[stephenplusplus]

Using this as an example: https://github.com/GoogleCloudPlatform/gcloud-node/blob/30817fcc10195da0136baefeb38b225986fb1c7e/lib/storage/index.js#L87-L90

if (!(this instanceof Storage)) {
  options = util.normalizeArguments(this, options);
  return new Storage(options);
}

Why do we only normalize if it's not an instance of Storage?

[stephenplusplus]

Related: #845 (comment)

[callmehiphop]

Why do we only normalize if it's not an instance of Storage?

If the current context is not an instance of a service (e.g. Storage), that implies that the context is probably gcloud, which is where we store global config.

[stephenplusplus]

So I'm wondering, since we only normalize under that condition, how do we move that logic to the Service constructor?

[callmehiphop]

So I'm wondering, since we only normalize under that condition, how do we move that logic to the Service constructor?

Ahh right, not sure if there's a way around that.. we might have to re-think things a little bit if we want to try and refactor that logic into the Service class.

[stephenplusplus]

Should we just leave it?

[callmehiphop]

Might be a good idea for now?