Skip to content

Commit

Permalink
feat: [alloydb] Add new field in GenerateClientCertificate v1 API t…
Browse files Browse the repository at this point in the history
…o allow AlloyDB connectors request client certs with metadata exchange support (#4785)

- [ ] Regenerate this pull request now.

docs: Clarify that `readPoolConfig` is required under certain circumstances, and fix doc formatting on `allocatedIpRange`.

PiperOrigin-RevId: 578577028

Source-Link: https://togithub.com/googleapis/googleapis/commit/c0a2b5427f7f5f5f2b4e7ff3e792936a470384a7

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4791ced8186e658805f2f75243da29c5dabb1f76
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFsbG95ZGIvLk93bEJvdC55YW1sIiwiaCI6IjQ3OTFjZWQ4MTg2ZTY1ODgwNWYyZjc1MjQzZGEyOWM1ZGFiYjFmNzYifQ==
  • Loading branch information
gcf-owl-bot[bot] authored Nov 3, 2023
1 parent 8d1ae22 commit d1f0a31
Show file tree
Hide file tree
Showing 8 changed files with 60 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,8 @@ message Cluster {
// instance IPs for this cluster will be created in the allocated range. The
// range name must comply with RFC 1035. Specifically, the name must be 1-63
// characters long and match the regular expression
// [a-z]([-a-z0-9]*[a-z0-9])?.
// Field name is intended to be consistent with CloudSQL.
// `[a-z]([-a-z0-9]*[a-z0-9])?`.
// Field name is intended to be consistent with Cloud SQL.
string allocated_ip_range = 2 [(google.api.field_behavior) = OPTIONAL];
}

Expand Down Expand Up @@ -835,7 +835,8 @@ message Instance {
// Configuration for query insights.
QueryInsightsInstanceConfig query_insights_config = 21;

// Read pool specific config.
// Read pool instance configuration.
// This is required if the value of instanceType is READ_POOL.
ReadPoolConfig read_pool_config = 14;

// Output only. The IP address for the Instance.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1358,6 +1358,11 @@ message GenerateClientCertificateRequest {

// Optional. The public key from the client.
string public_key = 5 [(google.api.field_behavior) = OPTIONAL];

// Optional. An optional hint to the endpoint to generate a client
// ceritificate that can be used by AlloyDB connectors to exchange additional
// metadata with the server after TLS handshake.
bool use_metadata_exchange = 6 [(google.api.field_behavior) = OPTIONAL];
}

// Message returned by a GenerateClientCertificate operation.
Expand Down
6 changes: 6 additions & 0 deletions packages/google-cloud-alloydb/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions packages/google-cloud-alloydb/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/google-cloud-alloydb/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ function main(parent) {
* Optional. The public key from the client.
*/
// const publicKey = 'abc123'
/**
* Optional. An optional hint to the endpoint to generate a client
* ceritificate that can be used by AlloyDB connectors to exchange additional
* metadata with the server after TLS handshake.
*/
// const useMetadataExchange = true

// Imports the Alloydb library
const {AlloyDBAdminClient} = require('@google-cloud/alloydb').v1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@
"segments": [
{
"start": 25,
"end": 80,
"end": 86,
"type": "FULL"
}
],
Expand All @@ -1310,6 +1310,10 @@
{
"name": "public_key",
"type": "TYPE_STRING"
},
{
"name": "use_metadata_exchange",
"type": "TYPE_BOOL"
}
],
"resultType": ".google.cloud.alloydb.v1.GenerateClientCertificateResponse",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,10 @@ export class AlloyDBAdminClient {
* default duration.
* @param {string} [request.publicKey]
* Optional. The public key from the client.
* @param {boolean} [request.useMetadataExchange]
* Optional. An optional hint to the endpoint to generate a client
* ceritificate that can be used by AlloyDB connectors to exchange additional
* metadata with the server after TLS handshake.
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down

0 comments on commit d1f0a31

Please sign in to comment.