refactor: remove unused deps (#261)

googleapis · Nov 9, 2018 · b48a5cb · b48a5cb
1 parent 190e75e
commit b48a5cb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 29 deletions.
diff --git a/packages/google-cloud-vision/package.json b/packages/google-cloud-vision/package.json
@@ -44,13 +44,11 @@
     "google-gax": "^0.20.0",
     "is": "^3.2.1",
     "lodash.merge": "^4.6.1",
-    "protobufjs": "^6.8.6",
-    "yargs": "^12.0.0"
+    "protobufjs": "^6.8.6"
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^2.3.0",
     "@google-cloud/storage": "^2.0.0",
-    "async": "^2.6.1",
     "codecov": "^3.0.2",
     "eslint": "^5.0.1",
     "eslint-config-prettier": "^3.0.0",

diff --git a/packages/google-cloud-vision/smoke-test/.eslintrc.yml b/packages/google-cloud-vision/smoke-test/.eslintrc.yml
@@ -2,5 +2,4 @@
 env:
   mocha: true
 rules:
-  node/no-unpublished-require: off
   no-console: off
diff --git a/packages/google-cloud-vision/system-test/.eslintrc.yml b/packages/google-cloud-vision/system-test/.eslintrc.yml
@@ -3,3 +3,4 @@ env:
   mocha: true
 rules:
   no-console: off
+  node/no-unsupported-features/es-syntax: off
diff --git a/packages/google-cloud-vision/system-test/vision.js b/packages/google-cloud-vision/system-test/vision.js
@@ -17,7 +17,6 @@
 'use strict';
 
 const assert = require('assert');
-const async = require('async');
 const fs = require('fs');
 const path = require('path');
 const {Storage} = require('@google-cloud/storage');
@@ -52,30 +51,13 @@ describe('Vision', function() {
     });
   });
 
-  after(function(done) {
-    storage.getBuckets(
-      {
-        prefix: TESTS_PREFIX,
-      },
-      function(err, buckets) {
-        if (err) {
-          done(err);
-          return;
-        }
-
-        function deleteBucket(bucket, callback) {
-          bucket.deleteFiles(function(err) {
-            if (err) {
-              callback(err);
-              return;
-            }
-
-            bucket.delete(callback);
-          });
-        }
-
-        async.each(buckets, deleteBucket, done);
-      }
+  after(async () => {
+    const [buckets] = await storage.getBuckets({prefix: TESTS_PREFIX});
+    await Promise.all(
+      buckets.map(async bucket => {
+        await bucket.deleteFiles();
+        await bucket.delete();
+      })
     );
   });