Skip to content

Commit

Permalink
updated FQDN's to googleapis.com with a trailing dot resulting in goo…
Browse files Browse the repository at this point in the history
…gleapis.com.
  • Loading branch information
ericuldall committed Apr 11, 2017
1 parent 184f9bb commit 7795d06
Show file tree
Hide file tree
Showing 63 changed files with 173 additions and 173 deletions.
4 changes: 2 additions & 2 deletions packages/bigquery/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ function BigQuery(options) {
}

var config = {
baseUrl: 'https://www.googleapis.com/bigquery/v2',
scopes: ['https://www.googleapis.com/auth/bigquery'],
baseUrl: 'https://www.googleapis.com./bigquery/v2',
scopes: ['https://www.googleapis.com./auth/bigquery'],
packageJson: require('../package.json')
};

Expand Down
2 changes: 1 addition & 1 deletion packages/bigquery/src/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ Table.prototype.createWriteStream = function(metadata) {
},
request: {
uri: format('{base}/{projectId}/jobs', {
base: 'https://www.googleapis.com/upload/bigquery/v2/projects',
base: 'https://www.googleapis.com./upload/bigquery/v2/projects',
projectId: self.bigQuery.projectId
})
}
Expand Down
4 changes: 2 additions & 2 deletions packages/bigquery/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@ describe('BigQuery', function() {

var calledWith = bq.calledWith_[0];

var baseUrl = 'https://www.googleapis.com/bigquery/v2';
var baseUrl = 'https://www.googleapis.com./bigquery/v2';
assert.strictEqual(calledWith.baseUrl, baseUrl);
assert.deepEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/bigquery'
'https://www.googleapis.com./auth/bigquery'
]);
assert.deepEqual(calledWith.packageJson, require('../package.json'));
});
Expand Down
2 changes: 1 addition & 1 deletion packages/bigquery/test/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ describe('BigQuery/Table', function() {

it('should pass the correct request uri', function(done) {
makeWritableStreamOverride = function(stream, options) {
var uri = 'https://www.googleapis.com/upload/bigquery/v2/projects/' +
var uri = 'https://www.googleapis.com./upload/bigquery/v2/projects/' +
table.bigQuery.projectId + '/jobs';
assert.equal(options.request.uri, uri);
done();
Expand Down
10 changes: 5 additions & 5 deletions packages/bigtable/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ function Bigtable(options) {
return new Bigtable(options);
}

var baseUrl = 'bigtable.googleapis.com';
var adminBaseUrl = 'bigtableadmin.googleapis.com';
var baseUrl = 'bigtable.googleapis.com.';
var adminBaseUrl = 'bigtableadmin.googleapis.com.';

var customEndpoint = options.apiEndpoint ||
process.env.BIGTABLE_EMULATOR_HOST;
Expand Down Expand Up @@ -345,9 +345,9 @@ function Bigtable(options) {
}
},
scopes: [
'https://www.googleapis.com/auth/bigtable.admin',
'https://www.googleapis.com/auth/bigtable.data',
'https://www.googleapis.com/auth/cloud-platform'
'https://www.googleapis.com./auth/bigtable.admin',
'https://www.googleapis.com./auth/bigtable.data',
'https://www.googleapis.com./auth/cloud-platform'
],
packageJson: require('../package.json')
};
Expand Down
14 changes: 7 additions & 7 deletions packages/bigtable/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,38 +136,38 @@ describe('Bigtable', function() {

var calledWith = bigtable.calledWith_[0];

assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com');
assert.strictEqual(calledWith.baseUrl, 'bigtable.googleapis.com.');
assert.strictEqual(calledWith.service, 'bigtable');
assert.strictEqual(calledWith.apiVersion, 'v2');
assert.strictEqual(calledWith.customEndpoint, false);

assert.deepEqual(calledWith.protoServices, {
Bigtable: googleProtoFiles('bigtable/v2/bigtable.proto'),
BigtableTableAdmin: {
baseUrl: 'bigtableadmin.googleapis.com',
baseUrl: 'bigtableadmin.googleapis.com.',
path: googleProtoFiles(
'bigtable/admin/v2/bigtable_table_admin.proto'),
service: 'bigtable.admin'
},
BigtableInstanceAdmin: {
baseUrl: 'bigtableadmin.googleapis.com',
baseUrl: 'bigtableadmin.googleapis.com.',
path: googleProtoFiles(
'bigtable/admin/v2/bigtable_instance_admin.proto'
),
service: 'bigtable.admin'
},
Operations: {
baseUrl: 'bigtableadmin.googleapis.com',
baseUrl: 'bigtableadmin.googleapis.com.',
path: googleProtoFiles('longrunning/operations.proto'),
service: 'longrunning',
apiVersion: 'v1'
}
});

assert.deepEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/bigtable.admin',
'https://www.googleapis.com/auth/bigtable.data',
'https://www.googleapis.com/auth/cloud-platform'
'https://www.googleapis.com./auth/bigtable.admin',
'https://www.googleapis.com./auth/bigtable.data',
'https://www.googleapis.com./auth/cloud-platform'
]);

assert.deepEqual(calledWith.packageJson, require('../package.json'));
Expand Down
4 changes: 2 additions & 2 deletions packages/common-grpc/test/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ describe('GrpcService', function() {
});

it('should store the baseUrl properly', function() {
var fakeBaseUrl = 'a.googleapis.com';
var fakeBaseUrl = 'a.googleapis.com.';

grpcLoadOverride = function() {
return MOCK_GRPC_API;
Expand Down Expand Up @@ -1914,7 +1914,7 @@ describe('GrpcService', function() {
});

it('should use the baseUrl override if applicable', function() {
var fakeBaseUrl = 'a.googleapis.com';
var fakeBaseUrl = 'a.googleapis.com.';
var fakeService = {};

grpcService.protos = {
Expand Down
4 changes: 2 additions & 2 deletions packages/compute/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ function Compute(options) {
}

var config = {
baseUrl: 'https://www.googleapis.com/compute/v1',
scopes: ['https://www.googleapis.com/auth/compute'],
baseUrl: 'https://www.googleapis.com./compute/v1',
scopes: ['https://www.googleapis.com./auth/compute'],
packageJson: require('../package.json')
};

Expand Down
2 changes: 1 addition & 1 deletion packages/compute/src/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ Service.prototype.delete = function(callback) {
Service.prototype.getHealth = function(group, callback) {
if (!is.string(group)) {
group = format('{baseUrl}/projects/{p}/zones/{z}/instanceGroups/{n}', {
baseUrl: 'https://www.googleapis.com/compute/v1',
baseUrl: 'https://www.googleapis.com./compute/v1',
p: this.parent.projectId,
z: group.zone.name || group.zone,
n: group.name
Expand Down
4 changes: 2 additions & 2 deletions packages/compute/src/vm.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ function VM(zone, name) {
this.waiters = [];

this.url = format('{base}/{project}/zones/{zone}/instances/{name}', {
base: 'https://www.googleapis.com/compute/v1/projects',
base: 'https://www.googleapis.com./compute/v1/projects',
project: zone.compute.projectId,
zone: zone.name,
name: this.name
Expand Down Expand Up @@ -382,7 +382,7 @@ VM.prototype.detachDisk = function(disk, callback) {
);

var deviceName;
var baseUrl = 'https://www.googleapis.com/compute/v1/';
var baseUrl = 'https://www.googleapis.com./compute/v1/';
var disks = metadata.disks || [];

// Try to find the deviceName by matching the source of the attached disks
Expand Down
4 changes: 2 additions & 2 deletions packages/compute/src/zone.js
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ Zone.prototype.createAutoscaler = function(name, config, callback) {

if (!/^https*:/.test(json.target)) {
json.target = [
'https://content.googleapis.com/compute/v1/projects/',
'https://content.googleapis.com./compute/v1/projects/',
this.compute.projectId,
'/zones/',
this.name,
Expand Down Expand Up @@ -554,7 +554,7 @@ Zone.prototype.createInstanceGroup = function(name, options, callback) {
* boot: true,
* initializeParams: {
* sourceImage:
* 'https://www.googleapis.com/compute/v1/projects' +
* 'https://www.googleapis.com./compute/v1/projects' +
* '/debian-cloud/global/images/debian-7-wheezy-v20150710'
* }
* }
Expand Down
10 changes: 5 additions & 5 deletions packages/compute/system-test/compute.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ describe('Compute', function() {
createInstanceGroupManager(
INSTANCE_GROUP_MANAGER_NAME,
[
'https://www.googleapis.com/compute/v1/projects',
'https://www.googleapis.com./compute/v1/projects',
compute.projectId,
'global/instanceTemplates',
INSTANCE_TEMPLATE_NAME
Expand Down Expand Up @@ -865,7 +865,7 @@ describe('Compute', function() {

it('should have created the right rule', function(done) {
var target = [
'https://www.googleapis.com/compute/v1/global/targetHttpProxies/',
'https://www.googleapis.com./compute/v1/global/targetHttpProxies/',
TARGET_PROXY_NAME
].join('');

Expand All @@ -886,7 +886,7 @@ describe('Compute', function() {

it('should set a new target', function(done) {
var target = [
'https://www.googleapis.com/compute/v1/projects/' + compute.projectId,
'https://www.googleapis.com./compute/v1/projects/' + compute.projectId,
'/global/targetHttpProxies/' + TARGET_PROXY_NAME
].join('');

Expand Down Expand Up @@ -947,7 +947,7 @@ describe('Compute', function() {

it('should have created the right rule', function(done) {
var target = [
'https://www.googleapis.com/compute/v1/projects/' + compute.projectId,
'https://www.googleapis.com./compute/v1/projects/' + compute.projectId,
'/zones/' + zone.name + '/targetInstances/' + TARGET_INSTANCE_NAME
].join('');

Expand Down Expand Up @@ -1243,7 +1243,7 @@ describe('Compute', function() {
assert.ifError(err);

var expectedMachineType = [
'https://www.googleapis.com/compute/v1',
'https://www.googleapis.com./compute/v1',
'zones',
zone.id,
'machineTypes',
Expand Down
4 changes: 2 additions & 2 deletions packages/compute/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,10 @@ describe('Compute', function() {

var calledWith = compute.calledWith_[0];

var baseUrl = 'https://www.googleapis.com/compute/v1';
var baseUrl = 'https://www.googleapis.com./compute/v1';
assert.strictEqual(calledWith.baseUrl, baseUrl);
assert.deepEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/compute'
'https://www.googleapis.com./auth/compute'
]);
assert.deepEqual(calledWith.packageJson, require('../package.json'));
});
Expand Down
4 changes: 2 additions & 2 deletions packages/compute/test/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ describe('Service', function() {
service.request = function(reqOpts) {
assert.deepEqual(reqOpts.json, {
group: [
'https://www.googleapis.com/compute/v1/projects/',
'https://www.googleapis.com./compute/v1/projects/',
COMPUTE.projectId,
'/zones/',
group.zone,
Expand All @@ -232,7 +232,7 @@ describe('Service', function() {
service.request = function(reqOpts) {
assert.deepEqual(reqOpts.json, {
group: [
'https://www.googleapis.com/compute/v1/projects/',
'https://www.googleapis.com./compute/v1/projects/',
COMPUTE.projectId,
'/zones/',
group.zone.name,
Expand Down
2 changes: 1 addition & 1 deletion packages/compute/test/vm.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ describe('VM', function() {

it('should localize the URL of the VM', function() {
assert.strictEqual(vm.url, [
'https://www.googleapis.com/compute/v1/projects',
'https://www.googleapis.com./compute/v1/projects',
COMPUTE.projectId,
'zones',
ZONE.name,
Expand Down
2 changes: 1 addition & 1 deletion packages/compute/test/zone.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('Zone', function() {

zone.request = function(reqOpts) {
var expectedTarget = [
'https://content.googleapis.com/compute/v1/projects/',
'https://content.googleapis.com./compute/v1/projects/',
COMPUTE.projectId,
'/zones/',
zone.name,
Expand Down
4 changes: 2 additions & 2 deletions packages/datastore/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ function Datastore(options) {
return new Datastore(options);
}

this.defaultBaseUrl_ = 'datastore.googleapis.com';
this.defaultBaseUrl_ = 'datastore.googleapis.com.';
this.determineBaseUrl_(options.apiEndpoint);

this.namespace = options.namespace;
Expand All @@ -312,7 +312,7 @@ function Datastore(options) {
customEndpoint: this.customEndpoint_,
service: 'datastore',
apiVersion: 'v1',
scopes: ['https://www.googleapis.com/auth/datastore'],
scopes: ['https://www.googleapis.com./auth/datastore'],
packageJson: require('../package.json'),
grpcMetadata: {
'google-cloud-resource-prefix': 'projects/' + this.projectId
Expand Down
6 changes: 3 additions & 3 deletions packages/datastore/src/v1/datastore_client.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var configData = require('./datastore_client_config');
var extend = require('extend');
var gax = require('google-gax');

var SERVICE_ADDRESS = 'datastore.googleapis.com';
var SERVICE_ADDRESS = 'datastore.googleapis.com.';

var DEFAULT_SERVICE_PORT = 443;

Expand All @@ -42,8 +42,8 @@ var CODE_GEN_NAME_VERSION = 'gapic/0.7.1';
* this service.
*/
var ALL_SCOPES = [
'https://www.googleapis.com/auth/cloud-platform',
'https://www.googleapis.com/auth/datastore'
'https://www.googleapis.com./auth/cloud-platform',
'https://www.googleapis.com./auth/datastore'
];

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/datastore/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('Datastore', function() {
});

it('should set the default base URL', function() {
assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com');
assert.strictEqual(datastore.defaultBaseUrl_, 'datastore.googleapis.com.');
});

it('should set default API connection details', function(done) {
Expand Down Expand Up @@ -163,7 +163,7 @@ describe('Datastore', function() {
assert.strictEqual(calledWith.service, 'datastore');
assert.strictEqual(calledWith.apiVersion, 'v1');
assert.deepEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/datastore'
'https://www.googleapis.com./auth/datastore'
]);
assert.deepEqual(calledWith.packageJson, require('../package.json'));
assert.deepEqual(calledWith.grpcMetadata, {
Expand Down
6 changes: 3 additions & 3 deletions packages/dns/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ function DNS(options) {
}

var config = {
baseUrl: 'https://www.googleapis.com/dns/v1',
baseUrl: 'https://www.googleapis.com./dns/v1',
scopes: [
'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
'https://www.googleapis.com/auth/cloud-platform'
'https://www.googleapis.com./auth/ndev.clouddns.readwrite',
'https://www.googleapis.com./auth/cloud-platform'
],
packageJson: require('../package.json')
};
Expand Down
6 changes: 3 additions & 3 deletions packages/dns/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ describe('DNS', function() {

var calledWith = dns.calledWith_[0];

var baseUrl = 'https://www.googleapis.com/dns/v1';
var baseUrl = 'https://www.googleapis.com./dns/v1';
assert.strictEqual(calledWith.baseUrl, baseUrl);
assert.deepEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/ndev.clouddns.readwrite',
'https://www.googleapis.com/auth/cloud-platform'
'https://www.googleapis.com./auth/ndev.clouddns.readwrite',
'https://www.googleapis.com./auth/cloud-platform'
]);
assert.deepEqual(calledWith.packageJson, require('../package.json'));
});
Expand Down
6 changes: 3 additions & 3 deletions packages/error-reporting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ applications running in almost any environment. Here's an introductory video:

1. Your application needs to use Node.js version 4.x or greater.
1. You need a [Google Cloud project](https://console.cloud.google.com). Your application can run anywhere, but errors are reported to a particular project.
1. [Enable the Stackdriver Error Reporting API](https://console.cloud.google.com/apis/api/clouderrorreporting.googleapis.com/overview) for your project.
1. [Enable the Stackdriver Error Reporting API](https://console.cloud.google.com/apis/api/clouderrorreporting.googleapis.com./overview) for your project.
1. The module will only send errors when the `NODE_ENV` environment variable is
set to `production` or the `ignoreEnvironmentCheck` property given in the
runtime configuration object is set to `true`.
Expand Down Expand Up @@ -56,13 +56,13 @@ If you are using [Google App Engine flexible environment](https://cloud.google.c

### Google Compute Engine

Your VM instances need to be created with the `https://www.googleapis.com/auth/cloud-platform` scope if created via the [gcloud](https://cloud.google.com/sdk) CLI or the Google Cloud Platform API, or by enabling at least one of the Stackdriver APIs if created through the browser-based console.
Your VM instances need to be created with the `https://www.googleapis.com./auth/cloud-platform` scope if created via the [gcloud](https://cloud.google.com/sdk) CLI or the Google Cloud Platform API, or by enabling at least one of the Stackdriver APIs if created through the browser-based console.

If you already have VMs that were created without API access and do not wish to recreate it, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere).

### Google Container Engine

Container Engine nodes need to also be created with the `https://www.googleapis.com/auth/cloud-platform` scope, which is configurable during cluster creation. Alternatively, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere). It's recommended that you store the service account credentials as [Kubernetes Secret](http://kubernetes.io/v1.1/docs/user-guide/secrets.html).
Container Engine nodes need to also be created with the `https://www.googleapis.com./auth/cloud-platform` scope, which is configurable during cluster creation. Alternatively, you can follow the instructions for using a service account under [running elsewhere](#running-elsewhere). It's recommended that you store the service account credentials as [Kubernetes Secret](http://kubernetes.io/v1.1/docs/user-guide/secrets.html).

## Running Elsewhere

Expand Down
Loading

0 comments on commit 7795d06

Please sign in to comment.