Merge pull request #234 from stephenplusplus/transaction-finalizing

datastore: transaction: only commit once
googleapis · Sep 19, 2014 · 245fc17 · 245fc17
2 parents ddc128c + df83eb0
commit 245fc17
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/datastore/transaction.js b/lib/datastore/transaction.js
@@ -312,12 +312,15 @@ Transaction.prototype.save = function(entities, callback) {
       callback(err);
       return;
     }
+    if (this.id) {
+      this.isFinalized = true;
+    }
     var autoInserted = (resp.mutation_result.insert_auto_id_key || []);
     autoInserted.forEach(function(key, index) {
       keys[insertIndexes[index]] = entity.keyFromKeyProto(key);
     });
     callback(null, isMultipleRequest ? keys : keys[0]);
-  });
+  }.bind(this));
 };
 
 /**
@@ -356,7 +359,12 @@ Transaction.prototype.delete = function(keys, callback) {
   }
   req = new pb.CommitRequest(req);
   var res = pb.CommitResponse;
-  this.makeReq('commit', req, res, callback);
+  this.makeReq('commit', req, res, function(err, response) {
+    if (this.id) {
+      this.isFinalized = true;
+    }
+    callback(err, response);
+  }.bind(this));
 };
 
 /**

diff --git a/regression/datastore.js b/regression/datastore.js
@@ -375,13 +375,13 @@ describe('datastore', function() {
         url: 'www.google.com'
       };
       ds.runInTransaction(function(t, tDone) {
-        ds.get(key, function(err, entity) {
+        t.get(key, function(err, entity) {
           assert.ifError(err);
           if (entity) {
             tDone();
             return;
           } else {
-            ds.save({ key: key, data: obj }, function(err) {
+            t.save({ key: key, data: obj }, function(err) {
               assert.ifError(err);
               tDone();
               return;