Skip to content

Commit

Permalink
feat!: drop node8 support, support for async iterators (#396)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
  • Loading branch information
alexander-fenster authored Mar 31, 2020
1 parent 7081137 commit 1fb3fbe
Show file tree
Hide file tree
Showing 32 changed files with 21,360 additions and 5,208 deletions.
3 changes: 3 additions & 0 deletions packages/google-cloud-monitoring/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/gts"
}
15 changes: 0 additions & 15 deletions packages/google-cloud-monitoring/.eslintrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion packages/google-cloud-monitoring/.jsdoc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019 Google LLC
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
8 changes: 0 additions & 8 deletions packages/google-cloud-monitoring/.prettierrc

This file was deleted.

17 changes: 17 additions & 0 deletions packages/google-cloud-monitoring/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

module.exports = {
...require('gts/.prettierrc.json')
}
10 changes: 6 additions & 4 deletions packages/google-cloud-monitoring/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc",
"engines": {
"node": ">=8.10.0"
"node": ">=10"
},
"repository": "googleapis/nodejs-monitoring",
"main": "build/src/index.js",
Expand Down Expand Up @@ -42,18 +42,19 @@
"prepare": "npm run compile"
},
"dependencies": {
"google-gax": "^1.14.1"
"google-gax": "^2.0.1"
},
"devDependencies": {
"@types/mocha": "^7.0.0",
"@types/node": "^12.12.27",
"@types/sinon": "^7.5.2",
"c8": "^7.1.0",
"codecov": "^3.6.5",
"eslint": "^6.0.0",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.0.0",
"gts": "^1.0.0",
"gts": "2.0.0-alpha.9",
"jsdoc": "^3.5.5",
"jsdoc-fresh": "^1.0.1",
"jsdoc-region-tag": "^1.0.2",
Expand All @@ -62,8 +63,9 @@
"null-loader": "^3.0.0",
"pack-n-play": "^1.0.0-2",
"prettier": "^1.13.7",
"sinon": "^9.0.1",
"ts-loader": "^6.2.1",
"typescript": "^3.7.0",
"typescript": "^3.8.3",
"webpack": "^4.41.6",
"webpack-cli": "^3.3.11"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-monitoring/samples/quickstart.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ async function quickstart() {

// Writes time series data
const [result] = await client.createTimeSeries(request);
console.log(`Done writing time series data.`, result);
console.log('Done writing time series data.', result);
}
// [END monitoring_quickstart]

Expand Down
Loading

0 comments on commit 1fb3fbe

Please sign in to comment.