Skip to content

Commit

Permalink
fix: [datacatalog] Change field behavior of the property "name" to ID…
Browse files Browse the repository at this point in the history
…ENTIFIER (#4925)

* docs: Change field behavior of the property "name" to IDENTIFIER

PiperOrigin-RevId: 596091522

Source-Link: googleapis/googleapis@4d7831d

Source-Link: googleapis/googleapis-gen@b6dfc3e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRhdGFjYXRhbG9nLy5Pd2xCb3QueWFtbCIsImgiOiJiNmRmYzNlYjY1YzFhMTcxZTk3MGVmZGU1ZWI1MzRiOGEwNzA5ZWRkIn0=

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: Change field behavior of the property "name" to IDENTIFIER

The solution follows guidelines from https://google.aip.dev/203#identifier and https://github.com/googleapis/googleapis/blob/master/google/api/field_behavior.proto#L91-L103.

PiperOrigin-RevId: 596643040

Source-Link: googleapis/googleapis@3c84a3c

Source-Link: googleapis/googleapis-gen@4c4a9f4
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRhdGFjYXRhbG9nLy5Pd2xCb3QueWFtbCIsImgiOiI0YzRhOWY0M2Y0YTRmN2Q4N2M5MzFjMTIxZTBiZDBmYmQ2MzkyNDY4In0=

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Jan 11, 2024
1 parent 86e0849 commit 07059f7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,10 @@ message Taxonomy {
string identity = 2;
}

// Output only. Resource name of this taxonomy in URL format.
// Identifier. Resource name of this taxonomy in URL format.
//
// Note: Policy tag manager generates unique taxonomy IDs.
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Required. User-defined name of this taxonomy.
//
Expand Down Expand Up @@ -290,10 +290,10 @@ message PolicyTag {
pattern: "projects/{project}/locations/{location}/taxonomies/{taxonomy}/policyTags/{policy_tag}"
};

// Output only. Resource name of this policy tag in the URL format.
// Identifier. Resource name of this policy tag in the URL format.
//
// The policy tag manager generates unique taxonomy IDs and policy tag IDs.
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Required. User-defined name of this policy tag.
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,9 @@ message Taxonomy {
string identity = 2;
}

// Output only. Resource name of this taxonomy, whose format is:
// Identifier. Resource name of this taxonomy, whose format is:
// "projects/{project_number}/locations/{location_id}/taxonomies/{id}".
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Required. User defined name of this taxonomy. It must: contain only unicode
// letters, numbers, underscores, dashes and spaces; not start or end with
Expand Down Expand Up @@ -246,9 +246,9 @@ message PolicyTag {
pattern: "projects/{project}/locations/{location}/taxonomies/{taxonomy}/policyTags/{policy_tag}"
};

// Output only. Resource name of this policy tag, whose format is:
// Identifier. Resource name of this policy tag, whose format is:
// "projects/{project_number}/locations/{location_id}/taxonomies/{taxonomy_id}/policyTags/{id}".
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Required. User defined name of this policy tag. It must: be unique within
// the parent taxonomy; contain only unicode letters, numbers, underscores,
Expand Down
8 changes: 4 additions & 4 deletions packages/google-cloud-datacatalog/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 07059f7

Please sign in to comment.