feat: support apiEndpoint override in client constructor (#112)

googleapis · Jun 5, 2019 · 02b2522 · 02b2522
1 parent d3273bb
commit 02b2522
Show file tree

Hide file tree

Showing 5 changed files with 77 additions and 7 deletions.
diff --git a/packages/google-cloud-securitycenter/src/v1/security_center_client.js b/packages/google-cloud-securitycenter/src/v1/security_center_client.js
@@ -56,14 +56,18 @@ class SecurityCenterClient {
    *     API remote host.
    */
   constructor(opts) {
+    opts = opts || {};
     this._descriptors = {};
 
+    const servicePath =
+      opts.servicePath || opts.apiEndpoint || this.constructor.servicePath;
+
     // Ensure that options include the service address and port.
     opts = Object.assign(
       {
         clientConfig: {},
         port: this.constructor.port,
-        servicePath: this.constructor.servicePath,
+        servicePath,
       },
       opts
     );
@@ -257,6 +261,14 @@ class SecurityCenterClient {
     return 'securitycenter.googleapis.com';
   }
 
+  /**
+   * The DNS address for this API service - same as servicePath(),
+   * exists for compatibility reasons.
+   */
+  static get apiEndpoint() {
+    return 'securitycenter.googleapis.com';
+  }
+
   /**
    * The port for this API service.
    */

diff --git a/packages/google-cloud-securitycenter/src/v1beta1/security_center_client.js b/packages/google-cloud-securitycenter/src/v1beta1/security_center_client.js
@@ -56,14 +56,18 @@ class SecurityCenterClient {
    *     API remote host.
    */
   constructor(opts) {
+    opts = opts || {};
     this._descriptors = {};
 
+    const servicePath =
+      opts.servicePath || opts.apiEndpoint || this.constructor.servicePath;
+
     // Ensure that options include the service address and port.
     opts = Object.assign(
       {
         clientConfig: {},
         port: this.constructor.port,
-        servicePath: this.constructor.servicePath,
+        servicePath,
       },
       opts
     );
@@ -248,6 +252,14 @@ class SecurityCenterClient {
     return 'securitycenter.googleapis.com';
   }
 
+  /**
+   * The DNS address for this API service - same as servicePath(),
+   * exists for compatibility reasons.
+   */
+  static get apiEndpoint() {
+    return 'securitycenter.googleapis.com';
+  }
+
   /**
    * The port for this API service.
    */

diff --git a/packages/google-cloud-securitycenter/synth.metadata b/packages/google-cloud-securitycenter/synth.metadata
@@ -1,19 +1,19 @@
 {
-  "updateTime": "2019-05-23T20:32:45.718938Z",
+  "updateTime": "2019-06-05T14:25:08.839987Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.20.0",
-        "dockerImage": "googleapis/artman@sha256:3246adac900f4bdbd62920e80de2e5877380e44036b3feae13667ec255ebf5ec"
+        "version": "0.23.1",
+        "dockerImage": "googleapis/artman@sha256:9d5cae1454da64ac3a87028f8ef486b04889e351c83bb95e83b8fab3959faed0"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "6a2f0244d6a07f2683e4a8cec514425bb27cfa03",
-        "internalRef": "249677018"
+        "sha": "47c142a7cecc6efc9f6f8af804b8be55392b795b",
+        "internalRef": "251635729"
       }
     },
     {

diff --git a/packages/google-cloud-securitycenter/test/gapic-v1.js b/packages/google-cloud-securitycenter/test/gapic-v1.js
@@ -23,6 +23,29 @@ const error = new Error();
 error.code = FAKE_STATUS_CODE;
 
 describe('SecurityCenterClient', () => {
+  it('has servicePath', () => {
+    const servicePath =
+      securityCenterModule.v1.SecurityCenterClient.servicePath;
+    assert(servicePath);
+  });
+
+  it('has apiEndpoint', () => {
+    const apiEndpoint =
+      securityCenterModule.v1.SecurityCenterClient.apiEndpoint;
+    assert(apiEndpoint);
+  });
+
+  it('has port', () => {
+    const port = securityCenterModule.v1.SecurityCenterClient.port;
+    assert(port);
+    assert(typeof port === 'number');
+  });
+
+  it('should create a client with no options', () => {
+    const client = new securityCenterModule.v1.SecurityCenterClient();
+    assert(client);
+  });
+
   describe('createSource', () => {
     it('invokes createSource without error', done => {
       const client = new securityCenterModule.v1.SecurityCenterClient({

diff --git a/packages/google-cloud-securitycenter/test/gapic-v1beta1.js b/packages/google-cloud-securitycenter/test/gapic-v1beta1.js
@@ -23,6 +23,29 @@ const error = new Error();
 error.code = FAKE_STATUS_CODE;
 
 describe('SecurityCenterClient', () => {
+  it('has servicePath', () => {
+    const servicePath =
+      securityCenterModule.v1beta1.SecurityCenterClient.servicePath;
+    assert(servicePath);
+  });
+
+  it('has apiEndpoint', () => {
+    const apiEndpoint =
+      securityCenterModule.v1beta1.SecurityCenterClient.apiEndpoint;
+    assert(apiEndpoint);
+  });
+
+  it('has port', () => {
+    const port = securityCenterModule.v1beta1.SecurityCenterClient.port;
+    assert(port);
+    assert(typeof port === 'number');
+  });
+
+  it('should create a client with no options', () => {
+    const client = new securityCenterModule.v1beta1.SecurityCenterClient();
+    assert(client);
+  });
+
   describe('createSource', () => {
     it('invokes createSource without error', done => {
       const client = new securityCenterModule.v1beta1.SecurityCenterClient({