Modified methods in ChangeRequest. #849

mderka · 2016-04-04T16:28:45Z

Added reload() and isDone() to change request. Also changed signature of applyTo().

See #679 for the discussion.

Added reload() and isDone() to change request. Also changed signature of applyTo().

coveralls · 2016-04-04T16:35:33Z

Changes Unknown when pulling 52567fd on mderka:cr-reload-done into * on GoogleCloudPlatform:master*.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

+  }
+
+  /**
+   * Retrieves the up-to-date information about the change request from Google Cloud DNS. Parameter


coveralls · 2016-04-04T18:09:18Z

Changes Unknown when pulling 3becc74 on mderka:cr-reload-done into * on GoogleCloudPlatform:master*.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

  }

  /**
   * Returns {@code true} if the change request has been completed. The function makes an API call
-   * to Google Cloud DNS in order request the status update.
+   * to Google Cloud DNS in order request the status update only if the status of the change request


@throws

Added @throws docs.

coveralls · 2016-04-04T18:30:27Z

Coverage increased (+0.007%) to 85.545% when pulling 8ad3e89 on mderka:cr-reload-done into d17e325 on GoogleCloudPlatform:master.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

   */
  public boolean isDone() {
    if (status() == Status.DONE) {
      return true;
    }
    ChangeRequest updated = reload(Dns.ChangeRequestOption.fields(Dns.ChangeRequestField.STATUS));
-    return updated.status() == Status.DONE;
-
+    return updated == null || updated.status() == Status.DONE;


coveralls · 2016-04-04T18:37:56Z

Coverage increased (+0.007%) to 85.545% when pulling 8ad3e89 on mderka:cr-reload-done into d17e325 on GoogleCloudPlatform:master.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

   */
-  public ChangeRequest applyTo(Dns.ChangeRequestOption... options) {
-    return dns.applyChangeRequest(zone, this, options);
+  public ChangeRequest applyTo(String zoneName, Dns.ChangeRequestOption... options) {


aozarov · 2016-04-04T18:59:12Z

Looks good to me. Few more small things. @mziccard any more feedback?

mziccard · 2016-04-04T19:05:07Z

Looks good to me!

mderka · 2016-04-04T19:09:11Z

Ok. I will squash and merge when travis finishes.

coveralls · 2016-04-04T19:35:36Z

Coverage increased (+0.007%) to 85.545% when pulling 74a4cf6 on mderka:cr-reload-done into d17e325 on GoogleCloudPlatform:master.

coveralls · 2016-04-04T19:41:26Z

Coverage increased (+0.02%) to 85.555% when pulling 74a4cf6 on mderka:cr-reload-done into d17e325 on GoogleCloudPlatform:master.

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.0 (#849) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/compatibility-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/confidence-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).

…1.1 (#849) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-kms).

…1575) (#849) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

…der to v2.5.7 (#849) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-recommender](https://togithub.com/googleapis/java-recommender) | `2.5.6` -> `2.5.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.7/compatibility-slim/2.5.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.5.7/confidence-slim/2.5.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender).

🤖 I have created a release *beep* *boop* --- ## [2.8.0](googleapis/java-core@v2.7.1...v2.8.0) (2022-06-21) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-core/issues/1440)) ([#836](googleapis/java-core#836)) ([49e9b68](googleapis/java-core@49e9b68)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.35.1 ([#843](googleapis/java-core#843)) ([d81fbf0](googleapis/java-core@d81fbf0)) * update dependency com.google.api:api-common to v2.2.1 ([#844](googleapis/java-core#844)) ([d711da9](googleapis/java-core@d711da9)) * update dependency com.google.api:gax-bom to v2.18.2 ([#849](googleapis/java-core#849)) ([d44a6d9](googleapis/java-core@d44a6d9)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 ([#846](googleapis/java-core#846)) ([981b634](googleapis/java-core@981b634)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.4.0 ([#838](googleapis/java-core#838)) ([8b04fb4](googleapis/java-core@8b04fb4)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.4.1 ([#848](googleapis/java-core#848)) ([78dd4ed](googleapis/java-core@78dd4ed)) * update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#839](googleapis/java-core#839)) ([a4b5158](googleapis/java-core@a4b5158)) * update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#845](googleapis/java-core#845)) ([24211fb](googleapis/java-core@24211fb)) * update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#840](googleapis/java-core#840)) ([93d825f](googleapis/java-core@93d825f)) * update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#841](googleapis/java-core#841)) ([7065ef0](googleapis/java-core@7065ef0)) * update dependency io.grpc:grpc-bom to v1.47.0 ([#842](googleapis/java-core#842)) ([3245109](googleapis/java-core@3245109)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Modified methods in ChangeRequest.

52567fd

Added reload() and isDone() to change request. Also changed signature of applyTo().

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Apr 4, 2016

mziccard reviewed Apr 4, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

}

/**

* Retrieves the up-to-date information about the change request from Google Cloud DNS. Parameter

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Reworded the documentation.

3becc74

mziccard reviewed Apr 4, 2016
View reviewed changes

Fixed the snipped and README. Removed possible NPE.

8ad3e89

Added @throws docs.

mderka force-pushed the cr-reload-done branch from 027ab00 to 8ad3e89 Compare April 4, 2016 18:27

mziccard reviewed Apr 4, 2016
View reviewed changes

aozarov reviewed Apr 4, 2016
View reviewed changes

One more throw and snippet.

0f3dc9a

Rephrased doc and improved IT.

74a4cf6

mderka merged commit 560d0b6 into googleapis:master Apr 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified methods in ChangeRequest. #849

Modified methods in ChangeRequest. #849

mderka commented Apr 4, 2016

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 4, 2016

mziccard commented Apr 4, 2016

mderka commented Apr 4, 2016

coveralls commented Apr 4, 2016

coveralls commented Apr 4, 2016

Modified methods in ChangeRequest. #849

Modified methods in ChangeRequest. #849

Conversation

mderka commented Apr 4, 2016

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Apr 4, 2016

mziccard commented Apr 4, 2016

mderka commented Apr 4, 2016

coveralls commented Apr 4, 2016

coveralls commented Apr 4, 2016