-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detailed javadoc to Blob and Storage signUrl #743
Conversation
* and its associated key. If a {@link AuthCredentials.ServiceAccountAuthCredentials} was passed | ||
* to {@link StorageOptions.Builder#authCredentials(AuthCredentials)} or the default credentials | ||
* are being used and the environment variable {@code GOOGLE_APPLICATION_CREDENTIALS} is set, then | ||
* {@code signUrl} will use that service account and associated key to sign the URL. If this |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thanks for taking this issue! Just a few nits from me. |
@@ -456,13 +457,40 @@ public WriteChannel writer(BlobWriteOption... options) { | |||
* Generates a signed URL for this blob. If you want to allow access to for a fixed amount of time |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Great. +1 for @ajkannan point about making the order clear. @OverclockedTim is that clear enough? |
This is definitely looking great, very helpful. Would you guys consider adding a comment similar to what @mziccard mentioned in #739: "Signing a URL involves signing with a private key. If the credentials used to authenticate do not expose one (this is the case for App Engine credentials, Compute Engine credentials and Google Cloud SDK credentials) there is nothing we can do to help."? That was the most helpful line for me personally, since I did not previously realize that those credential types didn't contain the necessary private keys. |
Yes, that is a good idea. Though I think we should direct that statement in the fallback option when |
I rephrased javadoc to address @ajkannan and @OverclockedTim comments. |
* want to require users to explicitly log in. | ||
* Generates a signed URL for this blob. If you want to allow access for a fixed amount of time to | ||
* this blob, you can use this method to generate a URL that is only valid within a certain time | ||
* period. This is particularly useful if you don't want publicly accessible blobs, but don't want |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks good. Feel free to merge with or without my suggestions. |
Comments fixed. Merging! |
Add more detailed javadoc to Blob and Storage signUrl
* chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 chore: include generated samples dir PiperOrigin-RevId: 450696442 Source-Link: googleapis/googleapis@da052c9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4800d1f2ea50e2cad9ce78b34185e9577029db5c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDgwMGQxZjJlYTUwZTJjYWQ5Y2U3OGIzNDE4NWU5NTc3MDI5ZGI1YyJ9 chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cies to v2.9.0 (googleapis#743) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.8.0` -> `2.9.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.9.0/compatibility-slim/2.8.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.9.0/confidence-slim/2.8.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.9.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​290-httpsgithubcomgoogleapisjava-shared-dependenciescomparev280v290-2022-03-28) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.8.0...v2.9.0) ##### Dependencies - guava 31.1 ([#&googleapis#8203;635](https://togithub.com/googleapis/java-shared-dependencies/issues/635)) ([0939b06](https://togithub.com/googleapis/java-shared-dependencies/commit/0939b063a79cd4ffafb49cf04861ce577e35efd6)) - update dependency com.fasterxml.jackson:jackson-bom to v2.13.2 ([#&googleapis#8203;626](https://togithub.com/googleapis/java-shared-dependencies/issues/626)) ([6014663](https://togithub.com/googleapis/java-shared-dependencies/commit/601466339c9631faa88033d1ff1e31582fb67b7b)) - update dependency com.fasterxml.jackson:jackson-bom to v2.13.2.20220324 ([#&googleapis#8203;636](https://togithub.com/googleapis/java-shared-dependencies/issues/636)) ([6c833fa](https://togithub.com/googleapis/java-shared-dependencies/commit/6c833faa7815147013999bfc2bb6935fd8fe6b34)) - update dependency com.google.api-client:google-api-client-bom to v1.33.4 ([#&googleapis#8203;642](https://togithub.com/googleapis/java-shared-dependencies/issues/642)) ([57bd912](https://togithub.com/googleapis/java-shared-dependencies/commit/57bd9124ce8981b7b3b5d0c87b7c1e5f935b7150)) - update dependency com.google.api:api-common to v2.1.5 ([#&googleapis#8203;637](https://togithub.com/googleapis/java-shared-dependencies/issues/637)) ([d3a00fa](https://togithub.com/googleapis/java-shared-dependencies/commit/d3a00fa5ce9908000122d8365fb2f2d0e388494b)) - update dependency com.google.auth:google-auth-library-bom to v1.6.0 ([#&googleapis#8203;631](https://togithub.com/googleapis/java-shared-dependencies/issues/631)) ([53dc7c2](https://togithub.com/googleapis/java-shared-dependencies/commit/53dc7c2fe255a6c7ca059dd414449bf96780f936)) - update dependency com.google.cloud:google-cloud-core-bom to v2.5.11 ([#&googleapis#8203;644](https://togithub.com/googleapis/java-shared-dependencies/issues/644)) ([4331dcc](https://togithub.com/googleapis/java-shared-dependencies/commit/4331dcc331e8377fcc57e5404321611186ca22cb)) - update dependency com.google.http-client:google-http-client-bom to v1.41.5 ([#&googleapis#8203;638](https://togithub.com/googleapis/java-shared-dependencies/issues/638)) ([e007d23](https://togithub.com/googleapis/java-shared-dependencies/commit/e007d2381bd388a1c199fc3f31d0b965f8ae592d)) - update dependency io.grpc:grpc-bom to v1.45.0 ([#&googleapis#8203;630](https://togithub.com/googleapis/java-shared-dependencies/issues/630)) ([20334e3](https://togithub.com/googleapis/java-shared-dependencies/commit/20334e30d256897cd7ef52c646e5c4549cd7ae69)) - update dependency org.threeten:threetenbp to v1.6.0 ([#&googleapis#8203;633](https://togithub.com/googleapis/java-shared-dependencies/issues/633)) ([1a2716d](https://togithub.com/googleapis/java-shared-dependencies/commit/1a2716d22e442c5cd6adea9449756b9ac3ddbf8e)) - update gax.version to v2.13.0 ([#&googleapis#8203;641](https://togithub.com/googleapis/java-shared-dependencies/issues/641)) ([b863746](https://togithub.com/googleapis/java-shared-dependencies/commit/b863746727fadd45c35198f58eb862f47fe14945)) - update google.common-protos.version to v2.8.0 ([#&googleapis#8203;639](https://togithub.com/googleapis/java-shared-dependencies/issues/639)) ([252afba](https://togithub.com/googleapis/java-shared-dependencies/commit/252afba1df8e4cfdf2574d127097b0978b7778c0)) - update google.core.version to v2.5.10 ([#&googleapis#8203;628](https://togithub.com/googleapis/java-shared-dependencies/issues/628)) ([fec6f51](https://togithub.com/googleapis/java-shared-dependencies/commit/fec6f5121384a04a389bad6f6477a9a5ce468016)) - update iam.version to v1.2.10 ([#&googleapis#8203;625](https://togithub.com/googleapis/java-shared-dependencies/issues/625)) ([0d7ca29](https://togithub.com/googleapis/java-shared-dependencies/commit/0d7ca2924bd24abe14883c173156bb4dc5fb90bf)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
🤖 I have created a release *beep* *boop* --- ### [1.2.7](googleapis/java-resourcemanager@v1.2.6...v1.2.7) (2022-03-29) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([googleapis#743](googleapis/java-resourcemanager#743)) ([3a7e696](googleapis/java-resourcemanager@3a7e696)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…onfig to v1.5.0 (googleapis#743) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-container).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…udgets to v2.3.2 (#743) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-billingbudgets](https://togithub.com/googleapis/java-billingbudgets) | `2.3.0` -> `2.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-billingbudgets/2.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-billingbudgets/2.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-billingbudgets/2.3.2/compatibility-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-billingbudgets/2.3.2/confidence-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billingbudgets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1MC40In0=-->
🤖 I have created a release *beep* *boop* --- ## [2.5.2](googleapis/java-bigqueryconnection@v2.5.1...v2.5.2) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#742](googleapis/java-bigqueryconnection#742)) ([a41bac5](googleapis/java-bigqueryconnection@a41bac5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…ements.txt (#743) * chore: update pip install statements in release scripts to use requirements.txt file
🤖 I have created a release *beep* *boop* --- ## [2.2.4](googleapis/java-websecurityscanner@v2.2.3...v2.2.4) (2022-09-15) ### Documentation * Publish Scan Run logging proto for documentation ([#739](googleapis/java-websecurityscanner#739)) ([fed4d7e](googleapis/java-websecurityscanner@fed4d7e)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#742](googleapis/java-websecurityscanner#742)) ([b797521](googleapis/java-websecurityscanner@b797521)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#746](googleapis/java-websecurityscanner#746)) ([0c1a751](googleapis/java-websecurityscanner@0c1a751)) * Update dependency joda-time:joda-time to v2.11.1 ([#738](googleapis/java-websecurityscanner#738)) ([367d773](googleapis/java-websecurityscanner@367d773)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.2.6](https://togithub.com/googleapis/java-os-login/compare/v2.2.5...v2.2.6) (2022-10-03) ### Dependencies * Update dependency charset-normalizer to v2.1.1 ([#741](https://togithub.com/googleapis/java-os-login/issues/741)) ([3b75ebd](https://togithub.com/googleapis/java-os-login/commit/3b75ebdbffbea6fdfb04f8dded74e318272bf245)) * Update dependency click to v8.1.3 ([#742](https://togithub.com/googleapis/java-os-login/issues/742)) ([a31156d](https://togithub.com/googleapis/java-os-login/commit/a31156df7b79a9ac871cc240ef6f5e08afa7b882)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#762](https://togithub.com/googleapis/java-os-login/issues/762)) ([decf589](https://togithub.com/googleapis/java-os-login/commit/decf58985da905a70413a4a2933dd74054d78536)) * Update dependency gcp-releasetool to v1.8.8 ([#737](https://togithub.com/googleapis/java-os-login/issues/737)) ([544ee2c](https://togithub.com/googleapis/java-os-login/commit/544ee2cef2d0e86b8d886da370333b9fc3d497d5)) * Update dependency google-api-core to v2.10.1 ([#743](https://togithub.com/googleapis/java-os-login/issues/743)) ([f0522d5](https://togithub.com/googleapis/java-os-login/commit/f0522d5774d2a10a17b0b21a860bb1650334acb2)) * Update dependency google-auth to v2.11.1 ([#738](https://togithub.com/googleapis/java-os-login/issues/738)) ([fc3b537](https://togithub.com/googleapis/java-os-login/commit/fc3b5377121e5c3268d41f55329f41e383ce291f)) * Update dependency google-auth to v2.12.0 ([#755](https://togithub.com/googleapis/java-os-login/issues/755)) ([aa212c5](https://togithub.com/googleapis/java-os-login/commit/aa212c5064f47c741082328c0d3a7bdfce1d5a70)) * Update dependency google-cloud-core to v2.3.2 ([#739](https://togithub.com/googleapis/java-os-login/issues/739)) ([b67bd85](https://togithub.com/googleapis/java-os-login/commit/b67bd85e362ccb2926fecbf913139d70d5a18c9a)) * Update dependency google-cloud-storage to v2.5.0 ([#756](https://togithub.com/googleapis/java-os-login/issues/756)) ([83b006a](https://togithub.com/googleapis/java-os-login/commit/83b006ad6fca281fbc2521d4f8f88c0683e6742a)) * Update dependency google-crc32c to v1.5.0 ([#757](https://togithub.com/googleapis/java-os-login/issues/757)) ([cdddc07](https://togithub.com/googleapis/java-os-login/commit/cdddc072a75a9582cb8ec78002fe00ff848d72b6)) * Update dependency importlib-metadata to v4.12.0 ([#758](https://togithub.com/googleapis/java-os-login/issues/758)) ([4228eac](https://togithub.com/googleapis/java-os-login/commit/4228eac668508d00bc08eea42dac30647516a6eb)) * Update dependency jeepney to v0.8.0 ([#759](https://togithub.com/googleapis/java-os-login/issues/759)) ([7f4e7e5](https://togithub.com/googleapis/java-os-login/commit/7f4e7e5fdc4629224b90eb62f4fb56e4b4bf9cf6)) * Update dependency jinja2 to v3.1.2 ([#744](https://togithub.com/googleapis/java-os-login/issues/744)) ([2fe1551](https://togithub.com/googleapis/java-os-login/commit/2fe1551fe6a8dce8a7b2d7964ce50235335d960a)) * Update dependency keyring to v23.9.3 ([#745](https://togithub.com/googleapis/java-os-login/issues/745)) ([4135da8](https://togithub.com/googleapis/java-os-login/commit/4135da8acfb45bf587eb45f1b960fada0335045c)) * Update dependency markupsafe to v2.1.1 ([#746](https://togithub.com/googleapis/java-os-login/issues/746)) ([b0bd633](https://togithub.com/googleapis/java-os-login/commit/b0bd633230739888cb648e1c25533be0b62d68db)) * Update dependency protobuf to v3.20.2 ([#747](https://togithub.com/googleapis/java-os-login/issues/747)) ([ee62667](https://togithub.com/googleapis/java-os-login/commit/ee626676cae459a4393a1d930add5c1804996723)) * Update dependency pyjwt to v2.5.0 ([#748](https://togithub.com/googleapis/java-os-login/issues/748)) ([77d5a02](https://togithub.com/googleapis/java-os-login/commit/77d5a020b9697db9385a878046166a9a9e3b4dfe)) * Update dependency typing-extensions to v4.3.0 ([#750](https://togithub.com/googleapis/java-os-login/issues/750)) ([6f961a8](https://togithub.com/googleapis/java-os-login/commit/6f961a83a7f859fb5a2aac488c3a6c7c38d74123)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…s#1687) (googleapis#743) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <[email protected]> Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
🤖 I have created a release *beep* *boop* --- ### [2.5.6](googleapis/java-core@v2.5.5...v2.5.6) (2022-03-01) ### Dependencies * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.6 ([#742](googleapis/java-core#742)) ([a96416b](googleapis/java-core@a96416b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/java-shared-dependencies@v2.13.0...v3.0.0) (2022-07-29) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-shared-dependencies/issues/1485)) ([#738](googleapis/java-shared-dependencies#738)) ([48b157d](googleapis/java-shared-dependencies@48b157d)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.35.2 ([#729](googleapis/java-shared-dependencies#729)) ([d518319](googleapis/java-shared-dependencies@d518319)) * update dependency com.google.api-client:google-api-client-bom to v2 ([#746](googleapis/java-shared-dependencies#746)) ([ef2b57a](googleapis/java-shared-dependencies@ef2b57a)) * update dependency com.google.api.grpc:grpc-google-common-protos to v2.9.2 ([#741](googleapis/java-shared-dependencies#741)) ([347269f](googleapis/java-shared-dependencies@347269f)) * update dependency com.google.auth:google-auth-library-bom to v1.8.0 ([#726](googleapis/java-shared-dependencies#726)) ([236bbb3](googleapis/java-shared-dependencies@236bbb3)) * update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#742](googleapis/java-shared-dependencies#742)) ([dabdbdf](googleapis/java-shared-dependencies@dabdbdf)) * update dependency com.google.cloud:first-party-dependencies to v2 ([#747](googleapis/java-shared-dependencies#747)) ([93b1ed8](googleapis/java-shared-dependencies@93b1ed8)) * update dependency com.google.cloud:grpc-gcp to v1.2.1 ([#751](googleapis/java-shared-dependencies#751)) ([618b00c](googleapis/java-shared-dependencies@618b00c)) * update dependency com.google.cloud:third-party-dependencies to v2 ([#748](googleapis/java-shared-dependencies#748)) ([afca3fd](googleapis/java-shared-dependencies@afca3fd)) * update dependency com.google.http-client:google-http-client-bom to v1.42.1 ([#730](googleapis/java-shared-dependencies#730)) ([4fdaad8](googleapis/java-shared-dependencies@4fdaad8)) * update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#749](googleapis/java-shared-dependencies#749)) ([68a82f4](googleapis/java-shared-dependencies@68a82f4)) * update dependency com.google.protobuf:protobuf-bom to v3.21.2 ([#722](googleapis/java-shared-dependencies#722)) ([68f570e](googleapis/java-shared-dependencies@68f570e)) * update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#756](googleapis/java-shared-dependencies#756)) ([7429507](googleapis/java-shared-dependencies@7429507)) * update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#759](googleapis/java-shared-dependencies#759)) ([f033db0](googleapis/java-shared-dependencies@f033db0)) * update dependency io.grpc:grpc-bom to v1.48.0 ([#752](googleapis/java-shared-dependencies#752)) ([9678d52](googleapis/java-shared-dependencies@9678d52)) * update dependency org.checkerframework:checker-qual to v3.23.0 ([#736](googleapis/java-shared-dependencies#736)) ([816d380](googleapis/java-shared-dependencies@816d380)) * update gax.version to v2.18.3 ([#731](googleapis/java-shared-dependencies#731)) ([5bbf1e1](googleapis/java-shared-dependencies@5bbf1e1)) * update gax.version to v2.18.4 ([#735](googleapis/java-shared-dependencies#735)) ([5161c6e](googleapis/java-shared-dependencies@5161c6e)) * update gax.version to v2.18.5 ([#758](googleapis/java-shared-dependencies#758)) ([608e040](googleapis/java-shared-dependencies@608e040)) * update gax.version to v2.18.6 ([#763](googleapis/java-shared-dependencies#763)) ([84b81e9](googleapis/java-shared-dependencies@84b81e9)) * update google.common-protos.version to v2.9.1 ([#724](googleapis/java-shared-dependencies#724)) ([62cd59a](googleapis/java-shared-dependencies@62cd59a)) * update google.core.version to v2.8.1 ([#725](googleapis/java-shared-dependencies#725)) ([d47af56](googleapis/java-shared-dependencies@d47af56)) * update google.core.version to v2.8.3 ([#760](googleapis/java-shared-dependencies#760)) ([33e38dc](googleapis/java-shared-dependencies@33e38dc)) * update google.core.version to v2.8.4 ([#762](googleapis/java-shared-dependencies#762)) ([5410450](googleapis/java-shared-dependencies@5410450)) * update google.core.version to v2.8.5 ([#764](googleapis/java-shared-dependencies#764)) ([4bc8c75](googleapis/java-shared-dependencies@4bc8c75)) * update iam.version to v1.5.0 ([#732](googleapis/java-shared-dependencies#732)) ([3e64541](googleapis/java-shared-dependencies@3e64541)) * update iam.version to v1.5.1 ([#737](googleapis/java-shared-dependencies#737)) ([5a85115](googleapis/java-shared-dependencies@5a85115)) * update iam.version to v1.5.2 ([#743](googleapis/java-shared-dependencies#743)) ([294ea85](googleapis/java-shared-dependencies@294ea85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This follows from #739 and tries to add a better javadoc to
Storage.signUrl
andBlob.signUrl