Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a versions option to BlobListOption #688

Merged
merged 3 commits into from
Mar 1, 2016
Merged

Add a versions option to BlobListOption #688

merged 3 commits into from
Mar 1, 2016

Conversation

aozarov
Copy link
Contributor

@aozarov aozarov commented Feb 29, 2016

Fixes #687.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 29, 2016
@aozarov aozarov added api: storage Issues related to the Cloud Storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 29, 2016
@aozarov aozarov removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 1, 2016
@aozarov
Copy link
Contributor Author

aozarov commented Mar 1, 2016

I added an integration test for listing with versioning enabled.

By doing so I realized 2 things:

  1. blob delete using bucket name and blob name does not work when versioning enabled as it seems
    to require a generation id (does not infer latest). Same applies to blob get without generation number (return not found).
  2. listing a bucket with generation enabled returns nothing if versioning is not enabled in the listing operation.

Is that expected? @Capstan @BrandonY

mziccard
mziccard reviewed Mar 1, 2016
View reviewed changes
gcloud-java-storage/src/test/java/com/google/gcloud/storage/it/ITStorageTest.java
import com.google.gcloud.storage.CopyWriter;
import com.google.gcloud.storage.HttpMethod;
import com.google.gcloud.storage.Storage;
import com.google.gcloud.storage.*;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

mziccard added a commit that referenced this pull request Mar 1, 2016
@mziccard
Merge pull request #688 from aozarov/master
3930ff9 
Add a versions option to BlobListOption
@mziccard mziccard merged commit 3930ff9 into googleapis:master Mar 1, 2016
@BrandonY
Copy link

BrandonY commented Mar 1, 2016

Deleting a blob without specifying a generation should always (and fully consistently) delete the LIVE version of said object, if any. If there is only an archived version, the delete will fail, as it cannot find a live version.

Listing the objects in a bucket with "versions" set to false ignores the existence of archived objects. If there are no live objects, it will return no results.

@aozarov
Copy link
Contributor Author

aozarov commented Mar 1, 2016

Thanks @BrandonY your description makes sense.

For the record, what confused me was that deleting a Blob (with also specifying its generation id) in a versioned bucket didn't actually delete it but rather removed its "live" status and therefore for completely deleting it (which is required if we want to delete its bucket) we need to call delete on it again.

@aozarov
Copy link
Contributor Author

aozarov commented Mar 2, 2016

Correction. Actually a delete with generation id is not only removing the "live" status but will completely
remove the blob. In our case, the delete happen after a listing with selective fields which didn't include
a generation id and therefore only function as a "live" status change.

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v24.…
7187810 
…1.2 (googleapis#688)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.1.1` -> `24.1.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/compatibility-slim/24.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/confidence-slim/24.1.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 0.34.0 (googleapis#688)
e80a1de 
🤖 I have created a release *beep* *boop*
---


## [0.34.0](googleapis/java-phishingprotection@v0.33.1...v0.34.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#685](googleapis/java-phishingprotection#685)) ([6a86faa](googleapis/java-phishingprotection@6a86faa))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.2.0 (googleapis#690)
a9d186e 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/java-os-login@v2.1.0...v2.2.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#694](googleapis/java-os-login#694)) ([a82410e](googleapis/java-os-login@a82410e))


### Bug Fixes

* make java.base fields accessible to fix java 17 runtime errors.  ([googleapis#688](googleapis/java-os-login#688)) ([51a9a6f](googleapis/java-os-login@51a9a6f))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#693](googleapis/java-os-login#693)) ([ecb4469](googleapis/java-os-login@ecb4469))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@gcf-owl-bot
chore: fix minor typos in README and pom templates (#1479) (#688)
5dfb257 
Source-Link: googleapis/synthtool@18d4e9b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@renovate-bot @gcf-owl-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
bf869d1 
…onfig to v1.5.1 (#688)

* build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 18, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-game-ser…
7c2b5ee 
…vers to v2.3.0 (#688)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-game-servers](https://togithub.com/googleapis/java-game-servers-v1beta) | `2.2.1` -> `2.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-game-servers).
github-actions bot pushed a commit that referenced this pull request Jul 27, 2022
@gcf-owl-bot
chore(bazel): update protobuf to v3.21.3 (#688)
c3bbf09 
- [ ] Regenerate this pull request now.

chore(bazel): update gax-java to 2.18.4

PiperOrigin-RevId: 463115700

Source-Link: googleapis/googleapis@52130a9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/6a4d9d9bb3afb20b0f5fa4f5d9f6740b1d0eb19a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
99e5960 
…onfig to v1.5.3 (#688)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.1` -> `1.5.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/compatibility-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/confidence-slim/1.5.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;153-httpsgithubcomgoogleapisjava-shared-configcomparev152v153-2022-07-27)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.2...v1.5.3)

##### Dependencies

-   update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#&#8203;497](https://togithub.com/googleapis/java-shared-config/issues/497)) ([1fc6ab4](https://togithub.com/googleapis/java-shared-config/commit/1fc6ab445624cd4f9c8b161d109f346a9e5ed09a))
-   Update doclet to latest version 1.6.0 ([38fb7c3](https://togithub.com/googleapis/java-shared-config/commit/38fb7c3957fb6c9b2da10f9e463cc93a8b80a3a4))

### [`v1.5.2`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;152-httpsgithubcomgoogleapisjava-shared-configcomparev151v152-2022-07-25)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.1...v1.5.2)

##### Dependencies

-   update dependency com.puppycrawl.tools:checkstyle to v10 ([#&#8203;435](https://togithub.com/googleapis/java-shared-config/issues/435)) ([bfc8ce1](https://togithub.com/googleapis/java-shared-config/commit/bfc8ce1deca6292147d002d3afe22a09840aa5d6))
-   update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 ([#&#8203;488](https://togithub.com/googleapis/java-shared-config/issues/488)) ([39b91ee](https://togithub.com/googleapis/java-shared-config/commit/39b91ee1283f0a5fbbe63e8bfd1ec97ab4ab377e))
-   update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#&#8203;489](https://togithub.com/googleapis/java-shared-config/issues/489)) ([cc3bcfa](https://togithub.com/googleapis/java-shared-config/commit/cc3bcfa2d6717441a8d5b5048fa78c2cf7aabf2b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billing).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@release-please
chore(main): release 0.9.4-SNAPSHOT (#688)
a1c87b3 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
52ab68f 
…1575) (#688)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this pull request Oct 6, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-memcache…
a9bad11 
… to v2.3.5 (#688)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-memcache](https://togithub.com/googleapis/java-memcache) | `2.3.4` -> `2.3.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/compatibility-slim/2.3.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/confidence-slim/2.3.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-memcache).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 2.11.0 (#688)
e9300fe 
🤖 I have created a release *beep* *boop*
---


## [2.11.0](googleapis/java-shared-dependencies@v2.10.0...v2.11.0) (2022-05-18)


### Features

* next release from main branch is 2.11.0 ([#674](googleapis/java-shared-dependencies#674)) ([323a20c](googleapis/java-shared-dependencies@323a20c))


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.13.3 ([#689](googleapis/java-shared-dependencies#689)) ([1bcea0e](googleapis/java-shared-dependencies@1bcea0e))
* update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#685](googleapis/java-shared-dependencies#685)) ([82ea316](googleapis/java-shared-dependencies@82ea316))
* update dependency com.google.api:api-common to v2.2.0 ([#690](googleapis/java-shared-dependencies#690)) ([d5e8571](googleapis/java-shared-dependencies@d5e8571))
* update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#691](googleapis/java-shared-dependencies#691)) ([067f7b9](googleapis/java-shared-dependencies@067f7b9))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#672](googleapis/java-shared-dependencies#672)) ([11311c4](googleapis/java-shared-dependencies@11311c4))
* update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#684](googleapis/java-shared-dependencies#684)) ([5153a98](googleapis/java-shared-dependencies@5153a98))
* update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#678](googleapis/java-shared-dependencies#678)) ([3d3a224](googleapis/java-shared-dependencies@3d3a224))
* update dependency io.grpc:grpc-bom to v1.46.0 ([#680](googleapis/java-shared-dependencies#680)) ([00f5d4a](googleapis/java-shared-dependencies@00f5d4a))
* update dependency org.checkerframework:checker-qual to v3.22.0 ([#683](googleapis/java-shared-dependencies#683)) ([275a37e](googleapis/java-shared-dependencies@275a37e))
* update gax.version to v2.17.0 ([#687](googleapis/java-shared-dependencies#687)) ([4b65150](googleapis/java-shared-dependencies@4b65150))
* update gax.version to v2.18.0 ([#692](googleapis/java-shared-dependencies#692)) ([f18503f](googleapis/java-shared-dependencies@f18503f))
* update google.core.version to v2.6.1 ([#671](googleapis/java-shared-dependencies#671)) ([a1bb345](googleapis/java-shared-dependencies@a1bb345))
* update google.core.version to v2.7.0 ([#693](googleapis/java-shared-dependencies#693)) ([d3a6ece](googleapis/java-shared-dependencies@d3a6ece))
* update iam.version to v1.3.2 ([#673](googleapis/java-shared-dependencies#673)) ([9d01376](googleapis/java-shared-dependencies@9d01376))
* update iam.version to v1.3.3 ([#679](googleapis/java-shared-dependencies#679)) ([27ee2b3](googleapis/java-shared-dependencies@27ee2b3))
* update iam.version to v1.3.4 ([#686](googleapis/java-shared-dependencies#686)) ([b860caf](googleapis/java-shared-dependencies@b860caf))
* update opencensus.version to v0.31.1 ([#682](googleapis/java-shared-dependencies#682)) ([1d0832c](googleapis/java-shared-dependencies@1d0832c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aozarov @BrandonY @mziccard @mderka @googlebot