Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: Close ResultSet from session keep-alive request #6331

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Spanner: Close ResultSet from session keep-alive request #6331

merged 1 commit into from
Oct 2, 2019

Conversation

sebright
Copy link

Fixes #6330

Closing the ResultSet also closes the span associated with the keep-alive
request, which fixes a tracing issue.

@sebright
Spanner: Close ResultSet from session keep-alive request
bf4e9e0 
Fixes googleapis#6330

Closing the ResultSet also closes the span associated with the keep-alive
request, which fixes a tracing issue.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #6331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6331   +/-   ##
=========================================
  Coverage     46.85%   46.85%           
- Complexity    28120    28135   +15     
=========================================
  Files          2601     2601           
  Lines        287259   287259           
  Branches      33359    33354    -5     
=========================================
  Hits         134596   134596           
  Misses       142429   142429           
  Partials      10234    10234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca141fc...bf4e9e0. Read the comment docs.

@skuruppu skuruppu requested a review from olavloite October 2, 2019 05:19
@olavloite olavloite merged commit 758cfd6 into googleapis:master Oct 2, 2019
@sebright
Copy link
Author

sebright commented Oct 2, 2019

Thanks for the review!

@sebright sebright deleted the close-session-keep-alive-result-set branch October 2, 2019 17:47
@chingor13 chingor13 mentioned this pull request Oct 2, 2019
Merged
@codyoss codyoss mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: ResultSet from session keep-alive request is not closed.
4 participants
@sebright @skuruppu @olavloite @googlebot