Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates DnsService interface and DnsOptions #597

Merged
merged 12 commits into from
Feb 2, 2016
Merged

Creates DnsService interface and DnsOptions #597

merged 12 commits into from
Feb 2, 2016

Conversation

mderka
Copy link

@mderka mderka commented Jan 29, 2016

No description provided.

@mderka mderka added the api: dns Issues related to the Cloud DNS API. label Jan 29, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2016
aozarov
aozarov reviewed Jan 29, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/dns/AbstractOption.java
/**
* A base class for options.
*/
public abstract class AbstractOption implements Serializable {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mderka
Copy link
Author

mderka commented Jan 30, 2016

Comments implemented. Ready for another pass.

@mderka
Copy link
Author

mderka commented Jan 30, 2016

Included forgotten files. It should be good now.

aozarov
aozarov reviewed Jan 30, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/dns/Dns.java
DESCENDING, ASCENDING;

public String selector() {
return this.name().toLowerCase();

This comment was marked as spam.

Sign in to view

@mderka
Copy link
Author

mderka commented Feb 1, 2016

All ready for another pass.

aozarov
aozarov reviewed Feb 1, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/dns/Dns.java
* specified. {@link ZoneField} provides a list of fields that can be used.
*/
public static ZoneListOption fields(ZoneField... fields) {
return new ZoneListOption(DnsRpc.Option.FIELDS, ZoneField.selector(fields));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented Feb 2, 2016

LGTM, please remove the static Field static import in Dns.java before you merge.

mderka added a commit that referenced this pull request Feb 2, 2016
@mderka
Merge pull request #597 from mderka/dns-options
c5566eb 
Creates DnsService interface and DnsOptions
@mderka mderka merged commit c5566eb into googleapis:dns-alpha Feb 2, 2016
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 0.10.4 (#573)
1a2dbe9 
🤖 I have created a release *beep* *boop*
---


## [0.10.4](https://togithub.com/googleapis/java-recommendations-ai/compare/v0.10.3...v0.10.4) (2022-10-03)


### Bug Fixes

* Fix recommendationengine resource name configuration ([#572](https://togithub.com/googleapis/java-recommendations-ai/issues/572)) ([2beea62](https://togithub.com/googleapis/java-recommendations-ai/commit/2beea629b8bd0dc2e0b934dac0c9a7c728ef71c1))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#574](https://togithub.com/googleapis/java-recommendations-ai/issues/574)) ([a7266ef](https://togithub.com/googleapis/java-recommendations-ai/commit/a7266ef9f0ad3a4be8222825b44025641cea63ba))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#601](https://togithub.com/googleapis/java-recommendations-ai/issues/601)) ([6fa10e1](https://togithub.com/googleapis/java-recommendations-ai/commit/6fa10e1206e125891b58cad6f78f1bdfeae247d4))
* Update dependency importlib-metadata to v4.12.0 ([#596](https://togithub.com/googleapis/java-recommendations-ai/issues/596)) ([cd541e7](https://togithub.com/googleapis/java-recommendations-ai/commit/cd541e72d4b0ac5a71aedf42f743ef66da7c191e))
* Update dependency jeepney to v0.8.0 ([#597](https://togithub.com/googleapis/java-recommendations-ai/issues/597)) ([32c3a1f](https://togithub.com/googleapis/java-recommendations-ai/commit/32c3a1f9e437a37fbc46981f8d0984d01d2b1785))
* Update dependency jinja2 to v3.1.2 ([#598](https://togithub.com/googleapis/java-recommendations-ai/issues/598)) ([6070770](https://togithub.com/googleapis/java-recommendations-ai/commit/6070770d7653bd1c5c33ddf717c6062926015882))
* Update dependency keyring to v23.9.3 ([#599](https://togithub.com/googleapis/java-recommendations-ai/issues/599)) ([454ca90](https://togithub.com/googleapis/java-recommendations-ai/commit/454ca90c112eb7c7da53a75ebf1cd31351af9c45))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Nov 16, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
7647aa9 
…cies to v3.0.6 (#597)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.4` -> `3.0.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.6/compatibility-slim/3.0.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/3.0.6/confidence-slim/3.0.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v3.0.6`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;306-httpsgithubcomgoogleapisjava-shared-dependenciescomparev305v306-2022-11-07)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.5...v3.0.6)

##### Dependencies

-   Update dependency com.fasterxml.jackson:jackson-bom to v2.14.0 ([#&#8203;901](https://togithub.com/googleapis/java-shared-dependencies/issues/901)) ([33c5511](https://togithub.com/googleapis/java-shared-dependencies/commit/33c55112ff485da1d7a0a32d8b6dade33aa04ff8))
-   Update dependency com.google.api-client:google-api-client-bom to v2.0.1 ([#&#8203;899](https://togithub.com/googleapis/java-shared-dependencies/issues/899)) ([4029e89](https://togithub.com/googleapis/java-shared-dependencies/commit/4029e89be507ddfa030515565fdb6fbf8997324e))
-   Update dependency com.google.api:api-common to v2.2.2 ([#&#8203;892](https://togithub.com/googleapis/java-shared-dependencies/issues/892)) ([5c59fbd](https://togithub.com/googleapis/java-shared-dependencies/commit/5c59fbd3c3cf3efbfda50420c8048e3ff257084c))
-   Update dependency com.google.cloud:grpc-gcp to v1.3.1 ([#&#8203;884](https://togithub.com/googleapis/java-shared-dependencies/issues/884)) ([9fffe24](https://togithub.com/googleapis/java-shared-dependencies/commit/9fffe243b631565a00b0a848a6c73163b1dd33a4))
-   Update dependency com.google.code.gson:gson to v2.10 ([#&#8203;887](https://togithub.com/googleapis/java-shared-dependencies/issues/887)) ([15017de](https://togithub.com/googleapis/java-shared-dependencies/commit/15017de39a35f90bc1b38b828edc23fdce524a07))
-   Update dependency com.google.http-client:google-http-client-bom to v1.42.3 ([#&#8203;893](https://togithub.com/googleapis/java-shared-dependencies/issues/893)) ([4c0de9b](https://togithub.com/googleapis/java-shared-dependencies/commit/4c0de9bd188bfab5fe126c8b01b4d7168f8a5079))
-   Update dependency com.google.protobuf:protobuf-bom to v3.21.9 ([#&#8203;889](https://togithub.com/googleapis/java-shared-dependencies/issues/889)) ([8576271](https://togithub.com/googleapis/java-shared-dependencies/commit/85762716d1bbb97c447f86451094fb8af2528470))
-   Update dependency io.grpc:grpc-bom to v1.50.2 ([#&#8203;878](https://togithub.com/googleapis/java-shared-dependencies/issues/878)) ([fd569af](https://togithub.com/googleapis/java-shared-dependencies/commit/fd569af1e5f1b195e2421fc9e02d8b67afe1c638))
-   Update dependency org.checkerframework:checker-qual to v3.27.0 ([#&#8203;896](https://togithub.com/googleapis/java-shared-dependencies/issues/896)) ([f0f7931](https://togithub.com/googleapis/java-shared-dependencies/commit/f0f7931937a0ed9a32fd87cd58c82b787d368242))
-   Update dependency org.threeten:threetenbp to v1.6.4 ([#&#8203;894](https://togithub.com/googleapis/java-shared-dependencies/issues/894)) ([899682d](https://togithub.com/googleapis/java-shared-dependencies/commit/899682d0405645d9d5288b298af2fda228414669))
-   Update gax.version to v2.19.5 ([#&#8203;903](https://togithub.com/googleapis/java-shared-dependencies/issues/903)) ([3e4d8b3](https://togithub.com/googleapis/java-shared-dependencies/commit/3e4d8b35d3f682b07326ffa0a3e552d097f25a65))
-   Update google.common-protos.version to v2.10.0 ([#&#8203;900](https://togithub.com/googleapis/java-shared-dependencies/issues/900)) ([53b54c3](https://togithub.com/googleapis/java-shared-dependencies/commit/53b54c35f3a7c19df488921a6077e7a9bfb0b103))
-   Update google.core.version to v2.8.23 ([#&#8203;885](https://togithub.com/googleapis/java-shared-dependencies/issues/885)) ([686dd7c](https://togithub.com/googleapis/java-shared-dependencies/commit/686dd7c8f541189302e8cac4ae72ed7d967b5b3f))
-   Update google.core.version to v2.8.24 ([#&#8203;890](https://togithub.com/googleapis/java-shared-dependencies/issues/890)) ([1effda3](https://togithub.com/googleapis/java-shared-dependencies/commit/1effda381c7b886f5ae4d2dac9473da821e655fe))
-   Update google.core.version to v2.8.27 ([#&#8203;902](https://togithub.com/googleapis/java-shared-dependencies/issues/902)) ([3bcb804](https://togithub.com/googleapis/java-shared-dependencies/commit/3bcb804dec4358ed0a9c6c35cf4c35f817821e9a))
-   Update iam.version to v1.6.6 ([#&#8203;886](https://togithub.com/googleapis/java-shared-dependencies/issues/886)) ([03d0690](https://togithub.com/googleapis/java-shared-dependencies/commit/03d0690f01f9217e31dd65d55c28a47f2f2deb22))
-   Update iam.version to v1.6.7 ([#&#8203;895](https://togithub.com/googleapis/java-shared-dependencies/issues/895)) ([6cebc20](https://togithub.com/googleapis/java-shared-dependencies/commit/6cebc205daa98b96a8b27b3fc3cd222319b27e59))

### [`v3.0.5`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;305-httpsgithubcomgoogleapisjava-shared-dependenciescomparev304v305-2022-10-20)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.4...v3.0.5)

##### Dependencies

-   Update dependency com.fasterxml.jackson:jackson-bom to v2.13.4.20221013 ([#&#8203;868](https://togithub.com/googleapis/java-shared-dependencies/issues/868)) ([ffa7272](https://togithub.com/googleapis/java-shared-dependencies/commit/ffa7272e6d4775905e64173b3617555ee355019d))
-   Update dependency com.google.auth:google-auth-library-bom to v1.12.0 ([#&#8203;870](https://togithub.com/googleapis/java-shared-dependencies/issues/870)) ([6e76f19](https://togithub.com/googleapis/java-shared-dependencies/commit/6e76f19133515b755b78185ce0135943e878a368))
-   Update dependency com.google.auth:google-auth-library-bom to v1.12.1 ([#&#8203;871](https://togithub.com/googleapis/java-shared-dependencies/issues/871)) ([f7f5dc2](https://togithub.com/googleapis/java-shared-dependencies/commit/f7f5dc26dd54f33954bdf5d43314020de58e055b))
-   Update dependency com.google.cloud:grpc-gcp to v1.3.0 ([#&#8203;867](https://togithub.com/googleapis/java-shared-dependencies/issues/867)) ([1927a92](https://togithub.com/googleapis/java-shared-dependencies/commit/1927a926c615eabbf0e7377c65232e0e5268220e))
-   Update dependency com.google.errorprone:error_prone_annotations to v2.16 ([#&#8203;865](https://togithub.com/googleapis/java-shared-dependencies/issues/865)) ([b1734ec](https://togithub.com/googleapis/java-shared-dependencies/commit/b1734ec1c20e7bdf2582b31fde4648aa9f8de2fe))
-   Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#&#8203;872](https://togithub.com/googleapis/java-shared-dependencies/issues/872)) ([1c303f2](https://togithub.com/googleapis/java-shared-dependencies/commit/1c303f2aa5145da4c93605a2d1088e8a3884de81))
-   Update dependency gcp-releasetool to v1.8.10 ([#&#8203;853](https://togithub.com/googleapis/java-shared-dependencies/issues/853)) ([c815a59](https://togithub.com/googleapis/java-shared-dependencies/commit/c815a5996d28676de015d5dd41e2b0405f4bb9dc))
-   Update dependency google-api-core to v2.10.2 ([#&#8203;858](https://togithub.com/googleapis/java-shared-dependencies/issues/858)) ([387a156](https://togithub.com/googleapis/java-shared-dependencies/commit/387a15662db0b20e72fe5bf961c02eb2bc4e75d9))
-   Update dependency io.grpc:grpc-bom to v1.50.0 ([#&#8203;866](https://togithub.com/googleapis/java-shared-dependencies/issues/866)) ([3d3d443](https://togithub.com/googleapis/java-shared-dependencies/commit/3d3d4434636e605f47082641e8e495bbce8f9515))
-   Update dependency io.grpc:grpc-bom to v1.50.1 ([#&#8203;873](https://togithub.com/googleapis/java-shared-dependencies/issues/873)) ([956309d](https://togithub.com/googleapis/java-shared-dependencies/commit/956309d76c9de46885711a77afbfce0d28971096))
-   Update dependency org.checkerframework:checker-qual to v3.26.0 ([#&#8203;852](https://togithub.com/googleapis/java-shared-dependencies/issues/852)) ([6926b33](https://togithub.com/googleapis/java-shared-dependencies/commit/6926b33b83d1aa63e0c78b7b8c72cd1d80e28ef3))
-   Update dependency org.threeten:threetenbp to v1.6.3 ([#&#8203;869](https://togithub.com/googleapis/java-shared-dependencies/issues/869)) ([fa4999b](https://togithub.com/googleapis/java-shared-dependencies/commit/fa4999b6310940e62456e83dad3ec76a7406a218))
-   Update dependency typing-extensions to v4.4.0 ([#&#8203;854](https://togithub.com/googleapis/java-shared-dependencies/issues/854)) ([43bd31b](https://togithub.com/googleapis/java-shared-dependencies/commit/43bd31b66eef50d82ecf8a692053f10eb385d5c1))
-   Update dependency zipp to v3.9.0 ([#&#8203;859](https://togithub.com/googleapis/java-shared-dependencies/issues/859)) ([a070ad0](https://togithub.com/googleapis/java-shared-dependencies/commit/a070ad04ef1bab5690487ba13dd4060827851edf))
-   Update gax.version to v2.19.4 ([#&#8203;875](https://togithub.com/googleapis/java-shared-dependencies/issues/875)) ([227bdd8](https://togithub.com/googleapis/java-shared-dependencies/commit/227bdd86f368b89309814c615828544c29871a5d))
-   Update google.core.version to v2.8.21 ([#&#8203;861](https://togithub.com/googleapis/java-shared-dependencies/issues/861)) ([8b502bd](https://togithub.com/googleapis/java-shared-dependencies/commit/8b502bd43760a2e52cf107567011d9c5132e74bd))
-   Update google.core.version to v2.8.22 ([#&#8203;879](https://togithub.com/googleapis/java-shared-dependencies/issues/879)) ([0360e93](https://togithub.com/googleapis/java-shared-dependencies/commit/0360e931dc45034d3c3c554f2c29ad7ea4a0a9bb))
-   Update iam.version to v1.6.3 ([#&#8203;857](https://togithub.com/googleapis/java-shared-dependencies/issues/857)) ([b39e683](https://togithub.com/googleapis/java-shared-dependencies/commit/b39e6838c3f3f6ef2b350efe8aec1b622893421a))
-   Update iam.version to v1.6.4 ([#&#8203;862](https://togithub.com/googleapis/java-shared-dependencies/issues/862)) ([85c9794](https://togithub.com/googleapis/java-shared-dependencies/commit/85c979401c34454b2d5681eed9d8b3b3679413be))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMSJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mderka @aozarov @googlebot