Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: add service api to read storage object in to output stream using direct download #5525

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Jun 20, 2019

towards #3929

Note: This pr just adds the service api. There would be follow up pr to this one which would add public api to download blob as a file or in to output stream using this service api.

@ajaaym ajaaym requested a review from a team as a code owner June 20, 2019 17:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@ajaaym ajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #5525 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5525      +/-   ##
============================================
- Coverage     50.86%   50.85%   -0.01%     
+ Complexity    24193    24192       -1     
============================================
  Files          2270     2270              
  Lines        230115   230151      +36     
  Branches      25009    25015       +6     
============================================
- Hits         117043   117041       -2     
- Misses       104435   104472      +37     
- Partials       8637     8638       +1
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/storage/spi/v1/StorageRpc.java 62.85% <ø> (ø) 0 <0> (ø) ⬇️
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.81% <0%> (-0.04%) 1 <0> (ø)
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 59.21% <0%> (-5.39%) 42 <0> (ø)
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d305770...d061eb0. Read the comment docs.

@ajaaym
Copy link
Contributor Author

ajaaym commented Jun 24, 2019

@frankyn @JesseLovelace can you please review?

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 27, 2019
@ajaaym ajaaym merged commit d67dc01 into googleapis:master Jul 9, 2019
@astroyang
Copy link

Is there an estimated time for the next step of adding a public api to download blob using this? @ajaaym

@ajaaym
Copy link
Contributor Author

ajaaym commented Jul 31, 2019

@astroyang #5791 is merged yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants