-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: add service api to read storage object in to output stream using direct download #5525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
============================================
- Coverage 50.86% 50.85% -0.01%
+ Complexity 24193 24192 -1
============================================
Files 2270 2270
Lines 230115 230151 +36
Branches 25009 25015 +6
============================================
- Hits 117043 117041 -2
- Misses 104435 104472 +37
- Partials 8637 8638 +1
Continue to review full report at Codecov.
|
@frankyn @JesseLovelace can you please review? |
Is there an estimated time for the next step of adding a public api to download blob using this? @ajaaym |
@astroyang #5791 is merged yesterday. |
towards #3929
Note: This pr just adds the service api. There would be follow up pr to this one which would add public api to download blob as a file or in to output stream using this service api.