Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logback: Make LoggingEventEnhancer more generic so can be used in more implementations #5522

Closed
wants to merge 2 commits into from
Closed

Logback: Make LoggingEventEnhancer more generic so can be used in more implementations #5522

wants to merge 2 commits into from

Conversation

abhinav-qlogic
Copy link

Fixes #5408

@abhinav-qlogic abhinav-qlogic requested a review from a team as a code owner June 20, 2019 06:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019 •
edited
Loading

Codecov Report

Merging #5522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5522   +/-   ##
=========================================
  Coverage     50.86%   50.86%           
  Complexity    24192    24192           
=========================================
  Files          2270     2270           
  Lines        230115   230115           
  Branches      25009    25009           
=========================================
  Hits         117041   117041           
  Misses       104436   104436           
  Partials       8638     8638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a7a3d...6003541. Read the comment docs.

@chingor13 chingor13 changed the title Logback:Fix Make LoggingEventEnhancer more generic so can be used in more implementations Logback: Make LoggingEventEnhancer more generic so can be used in more implementations Jun 26, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 27, 2019
@chingor13
Copy link
Contributor

This looks like a breaking change to the interface.

@sduskis
Copy link
Contributor

sduskis commented Jul 1, 2019

As per @chingor13's comments, this change is not backwards compatible. I think that there ought to be more thought about this change and how it improves the customer experience.

@sduskis sduskis closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make LoggingEventEnhancer more generic so can be used in more implementations
7 participants
@abhinav-qlogic @chingor13 @sduskis @googlebot @pmakani @yoshi-automation @yoshi-kokoro